refactor: use AexEncryption::new

[Its-Just-Nans]

• use the use constructor
• remove the impl FixedSizeBLock

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of AES encryption extra fields (AexEncryption) within the zip crate. The primary goal is to simplify the serialization process by moving the little-endian conversion logic directly into the AexEncryption struct via a to_le method and utilizing its new constructor. This change removes the dependency on the FixedSizeBlock trait for AexEncryption, leading to cleaner and more direct data handling when writing AES metadata to zip archives.

Highlights

• Refactored AexEncryption: The AexEncryption struct was refactored to use its new constructor and a dedicated to_le method for little-endian conversion, simplifying its serialization logic.
• Removed FixedSizeBlock Trait: The FixedSizeBlock trait implementation for AexEncryption was removed, streamlining the data structure's definition and reducing its dependencies.
• Simplified AES Extra Data Writing: The ZipWriter was updated to leverage the refactored AexEncryption for writing AES extra data, replacing manual byte array construction with a more direct and type-safe approach.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

⚠️ Review Failed

I was unable to finalize my review because the pull request head or merge base was modified since I began my review. Please try again.

Request ID: 683ce36d-83af-5cfc-82cf-815b515a5e38

[gemini-code-assist]

Code Review

This pull request refactors the handling of AexEncryption extra fields by using its constructor AexEncryption::new and removing the FixedSizeBlock implementation. This centralizes the logic for creating the AES extra field data, improving code clarity and maintainability. The changes are well-executed and simplify the codebase. I have one suggestion to further improve the robustness of the code.