FV CI integration#2
Merged
Merged
Conversation
Use fully-qualified paths for trait methods that aren't in scope, and Self:: for the struct's own field. Silences -D warnings in the docs job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Tells contributors how to regenerate the Lean files when drift is detected, so CI failures are self-explanatory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
check_all compares Ragu.lean against generated_ragu_root, but export_all never wrote it. When a target was added or removed, running export alone could not make check pass, which made the existing remediation hint misleading. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Re-adds point_negate.rs to lean_extraction (removed in 513effa) and introduces the hand-written Instances/Point/Negate.lean wrapper that ties the autogenerated operations/output to the Circuits.Point.Negate formal circuit via FormalCircuit.isGeneralFormalCircuit. Ragu.lean is regenerated to import the new Instances.Point.Negate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Matches the Lean module name (AddIncomplete) and aligns with the point_double/Double and point_negate/Negate conventions. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Replaces an assert_eq! with a proper Result return, matching the error handling style of the rest of the function. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The dedicated variant matches what the error actually is (a fixed-length vector mismatch) and includes expected/actual in structured form. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The doc claimed the variant held a first_idx, but there is none. Indices are implicit in the op-sequence position, matching Lean's Operation.witness representation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.