Fall back when a translation is stored as an empty string - #148
Open
shreyanshj10 wants to merge 1 commit into
Open
shreyanshj10 wants to merge 1 commit into
shreyanshj10 wants to merge 1 commit into
Conversation
shreyanshj10
marked this pull request as ready for review
September 29, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a translation is stored as an empty string in
i18n, which happens easily through the admin withActiveLanguageMixin, the fallback works when reading the attribute but not in queries.TranslatedVirtualField.__get__()already skips an empty translation and continues down the fallback chain (test_fallback_getting_CharFieldcovers that).as_expression()builds aCOALESCE, which only skipsNULL, sovalues(),filter()andorder_by()hand back the empty string instead of the fallback value.I wrapped every
i18nlookup in the coalesce chain inNULLIF(<lookup>, ''), so an empty translation is treated as missing there too. The lookup for the default language points at the original field and is the last resort of the chain, so I left it as it is; that keeps the current result when every value is empty.Added
FallbackEmptyStringTestintests/test_querysets.py, coveringvalues_list(),filter()and a model usingfallback_language_field.Fixes #139