ci(nix): only run Nix CI on flake and packaging changes - #1250
Open
davidbudnick wants to merge 1 commit into
Open
ci(nix): only run Nix CI on flake and packaging changes#1250davidbudnick wants to merge 1 commit into
davidbudnick wants to merge 1 commit into
Conversation
Greptile SummaryNarrows pull-request triggers for the two-architecture Nix build while retaining scheduled and manual validation.
Confidence Score: 5/5The PR appears safe to merge, with the delayed detection of source-driven Nix failures explicitly accepted as its intended tradeoff. The retained filters still run Nix CI for this workflow and relevant Nix packaging changes, while scheduled and manual execution continue to cover deliberately deferred source-integration drift.
|
| Filename | Overview |
|---|---|
| .github/workflows/nix.yml | Narrows Nix CI pull-request path filters as documented while preserving validation for Nix packaging and workflow changes. |
Reviews (1): Last reviewed commit: "ci(nix): only run Nix CI on flake and pa..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop running the two-arch Nix build on ordinary feature PRs. Nix CI now triggers on PRs only when the flake or
packaging/linuxactually changes. The Monday job still catches Cargo/source drift.Why
Nix CI was matching
Cargo.toml,Cargo.lock,crates/**/Cargo.toml,build.rs, icons, and the example config. That is most feature PRs. Each run is a fullnix buildon x86_64 and aarch64 (typically 17–20 minutes each, ~40 billed minutes per push). The workflow already has 658 runs. Linux cargo CI already compiles those same Cargo.toml changes.Residual risk
A PR that adds a new native/system dependency without touching
packaging/linuxstays green until the Monday cron (or a manualworkflow_dispatch). That is the tradeoff for not rebuilding Nix on every crate bump.Test plan
.github/workflows/nix.yml)