Repository navigation
core: remove obsolete IBD backup watcher - #286
BenWestgate wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52830af6e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
52830af to
a6fb90b
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review, posted at the maintainer's request.
ACK a6fb90b code. Legacy wallet-watch is now removed and process matching is scoped to the exact managed script paths; supported-Tails upgrade validation remains the merge gate.
03134e7 to
fddc710
Compare
a6fb90b to
633f61c
Compare
This comment has been minimized.
This comment has been minimized.
BenWestgate
left a comment
There was a problem hiding this comment.
Codex current-head review at 633f61c: no findings. The updater removes only the named legacy wallet/Sparrow/watcher artifacts, terminates matching per-user obsolete watcher process trees, preserves Bitcoin Core wallet data, and the replacement codex32 checkout is pinned and re-verified by exact commit plus clean-tree checks before execution.
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head security verification for issue #265 at 633f61c: the audited recursive-process finding is closed by construction. bails/.local/bin/ibd-progress is deleted, its autostart/state is removed during install/update cleanup, and the cleanup targets only processes whose /proc/<pid>/cmdline contains the exact legacy watcher path before recursively stopping that legacy process tree. No replacement recursive watcher is introduced. Exact-head Lint CI is green and there are no unresolved review threads. This is a verification of the #265 finding, not an overall ACK of the much larger legacy-wallet/removal stack carried by this PR; supported-Tails upgrade/restart qualification in the PR body remains required.
Remove the recursive debug.log-based IBD watcher and legacy backup-wizard state, and clean up only CipherStick-owned legacy watcher processes/files during upgrade. Closes #265
633f61c to
5dff857
Compare
Closes #265.
ibd-progressduplicates Bitcoin Core's own synchronization UI, recursively scrapesdebug.log, and still carries the mandatory backup/wallet flow removed from CipherStick's supported wallet path. #265 explicitly allows removing the watcher when no extra completion notification is needed, so this takes the lower-maintenance path instead of adding another polling daemon.Changes:
bails/.local/bin/ibd-progressentirely;ibd-progress/wallet-watchprocess trees and remove their obsolete executables, autostart files, andibd_backedupmarker;/proc/<pid>/cmdlinebefore terminating anything;Local checks:
git diff --checkbash -n bHuman/Tails gate still required: exercise upgrade/restart behavior on the supported Tails release and confirm no obsolete watcher or backup wizard returns.