Skip to content

core: remove obsolete IBD backup watcher - #286

Open
BenWestgate wants to merge 1 commit into
masterfrom
265-remove-ibd-progress
Open

BenWestgate wants to merge 1 commit into
masterfrom
265-remove-ibd-progress

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner

Closes #265.

ibd-progress duplicates Bitcoin Core's own synchronization UI, recursively scrapes debug.log, and still carries the mandatory backup/wallet flow removed from CipherStick's supported wallet path. #265 explicitly allows removing the watcher when no extra completion notification is needed, so this takes the lower-maintenance path instead of adding another polling daemon.

Changes:

  • remove bails/.local/bin/ibd-progress entirely;
  • remove its obsolete ShellCheck exclusion;
  • during install/update cleanup, stop running CipherStick-owned legacy ibd-progress / wallet-watch process trees and remove their obsolete executables, autostart files, and ibd_backedup marker;
  • match the exact legacy script path in /proc/<pid>/cmdline before terminating anything;
  • leave Persistent Storage user data untouched.

Local checks:

  • git diff --check
  • bash -n b
  • live cleanup smoke test launched a temporary legacy watcher with a child process, verified both were terminated, verified the managed legacy files/state were removed, and verified unrelated user data remained.

Human/Tails gate still required: exercise upgrade/restart behavior on the supported Tails release and confirm no obsolete watcher or backup wizard returns.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 52830af6e5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread b
Comment thread b
@BenWestgate
BenWestgate force-pushed the 265-remove-ibd-progress branch from 52830af to a6fb90b Compare September 29, 2026 03:42

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-generated review, posted at the maintainer's request.

ACK a6fb90b code. Legacy wallet-watch is now removed and process matching is scoped to the exact managed script paths; supported-Tails upgrade validation remains the merge gate.

@chatgpt-codex-connector

This comment has been minimized.

Base automatically changed from 215-python-codex32-restore to master October 1, 2026 04:47

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex current-head review at 633f61c: no findings. The updater removes only the named legacy wallet/Sparrow/watcher artifacts, terminates matching per-user obsolete watcher process trees, preserves Bitcoin Core wallet data, and the replacement codex32 checkout is pinned and re-verified by exact commit plus clean-tree checks before execution.

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head security verification for issue #265 at 633f61c: the audited recursive-process finding is closed by construction. bails/.local/bin/ibd-progress is deleted, its autostart/state is removed during install/update cleanup, and the cleanup targets only processes whose /proc/<pid>/cmdline contains the exact legacy watcher path before recursively stopping that legacy process tree. No replacement recursive watcher is introduced. Exact-head Lint CI is green and there are no unresolved review threads. This is a verification of the #265 finding, not an overall ACK of the much larger legacy-wallet/removal stack carried by this PR; supported-Tails upgrade/restart qualification in the PR body remains required.

Remove the recursive debug.log-based IBD watcher and legacy backup-wizard state, and clean up only CipherStick-owned legacy watcher processes/files during upgrade.

Closes #265
@BenWestgate
BenWestgate force-pushed the 265-remove-ibd-progress branch from 633f61c to 5dff857 Compare October 7, 2026 08:31
@chatgpt-codex-connector

This comment has been minimized.

1 similar comment
@chatgpt-codex-connector

This comment has been minimized.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace ibd-progress backup wizard with a Core RPC notification

1 participant