Skip to content

ui: fix Welcome and chainstate dialog visuals - #301

Open
BenWestgate wants to merge 1 commit into
masterfrom
claude/busy-bell-dialogs
Open

BenWestgate wants to merge 1 commit into
masterfrom
claude/busy-bell-dialogs

Conversation

@BenWestgate

@BenWestgate BenWestgate commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Two small zenity fixes seen while testing a fresh install on Tails.

Welcome dialog shape. The first-install Welcome dialog in install-core set no width, so zenity wrapped its paragraphs into a tall, narrow column. It now passes --width=600, which Tails' zenity honours. The dialog's text is unchanged: it keeps the paragraphs adapted from Bitcoin Core's own first-run dialog. (An intermediate commit shortened them; it is reverted here, since CipherStick users run the same Bitcoin Core and should see the same explanation.)

Chainstate dialog icon. The "Chainstate preloaded to RAM" and "Your computer is low on memory" dialogs in chainstate-preload used drive-harddisk-solidstate, which suggests disk rather than memory. Adwaita has no RAM icon, so both now use the stock computer icon: the chainstate moves off the USB stick into the computer's memory. No new icon files are added.

Testing: --width confirmed on Tails. shellcheck with CI's flags reports nothing new.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LvEHMDeHvYQYDEkpJn95X8

Copy link
Copy Markdown
Owner Author

github-advanced-security is red here, but not because of this change. The check fails on every open PR in this repo, including ones that don't touch any of these files, and the failing run has no title, summary or findings. It comes from a repository setting, and I've been told to ignore it. No fix exists for it in this PR's scope. All the other checks pass: CodeQL, Analyze (actions), Check shell code and dependency-review.


Generated by Claude Code

@BenWestgate
BenWestgate marked this pull request as ready for review October 1, 2026 09:54
@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate BenWestgate changed the title ui: fix Welcome and chainstate dialog visuals ui: fix Welcome and chainstate dialogs Oct 1, 2026
@BenWestgate BenWestgate changed the title ui: fix Welcome and chainstate dialogs ui: fix Welcome and chainstate dialog visuals Oct 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector

This comment has been minimized.

@BenWestgate
BenWestgate force-pushed the claude/busy-bell-dialogs branch from a9882b2 to 91b927b Compare October 3, 2026 07:39

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex current-head review at 91b927b: no findings. The diff is limited to a 600px Welcome-dialog width hint and replacing the misleading storage icon with the stock computer icon; neither changes setup control flow.

The first-install Welcome dialog set no width, so zenity wrapped its
paragraphs into a tall, narrow column. Give it --width=600, which
Tails' zenity honours.

The chainstate preload dialogs used drive-harddisk-solidstate, which
suggests disk rather than memory. Adwaita has no RAM icon, so use the
stock computer icon: the chainstate moves into the computer's memory.
@BenWestgate
BenWestgate force-pushed the claude/busy-bell-dialogs branch from 91b927b to 9b4efd3 Compare October 7, 2026 08:36

Copy link
Copy Markdown
Owner Author

Rebased onto master and squashed into one commit (9b4efd3) to fix the conflict with #303 in chainstate-preload. The diff is the same as before: two icon changes and --width=600 on the Welcome dialog. If #283 lands first, it deletes the "Chainstate preloaded" dialog, and then only the low-memory icon change from this PR remains.


Generated by Claude Code

@BenWestgate BenWestgate left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI-assisted current-head review: ACK 9b4efd3. The Welcome width and stock notification icons change presentation only. No code findings; confirm the dialogs on supported Tails.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants