Repository navigation
ui: fix Welcome and chainstate dialog visuals - #301
BenWestgate wants to merge 1 commit into
Conversation
|
Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
|
@codex review Generated by Claude Code |
This comment has been minimized.
This comment has been minimized.
a9882b2 to
91b927b
Compare
BenWestgate
left a comment
There was a problem hiding this comment.
Codex current-head review at 91b927b: no findings. The diff is limited to a 600px Welcome-dialog width hint and replacing the misleading storage icon with the stock computer icon; neither changes setup control flow.
The first-install Welcome dialog set no width, so zenity wrapped its paragraphs into a tall, narrow column. Give it --width=600, which Tails' zenity honours. The chainstate preload dialogs used drive-harddisk-solidstate, which suggests disk rather than memory. Adwaita has no RAM icon, so use the stock computer icon: the chainstate moves into the computer's memory.
91b927b to
9b4efd3
Compare
|
Rebased onto master and squashed into one commit (9b4efd3) to fix the conflict with #303 in Generated by Claude Code |
BenWestgate
left a comment
There was a problem hiding this comment.
AI-assisted current-head review: ACK 9b4efd3. The Welcome width and stock notification icons change presentation only. No code findings; confirm the dialogs on supported Tails.
Two small zenity fixes seen while testing a fresh install on Tails.
Welcome dialog shape. The first-install Welcome dialog in
install-coreset no width, so zenity wrapped its paragraphs into a tall, narrow column. It now passes--width=600, which Tails' zenity honours. The dialog's text is unchanged: it keeps the paragraphs adapted from Bitcoin Core's own first-run dialog. (An intermediate commit shortened them; it is reverted here, since CipherStick users run the same Bitcoin Core and should see the same explanation.)Chainstate dialog icon. The "Chainstate preloaded to RAM" and "Your computer is low on memory" dialogs in
chainstate-preloaduseddrive-harddisk-solidstate, which suggests disk rather than memory. Adwaita has no RAM icon, so both now use the stockcomputericon: the chainstate moves off the USB stick into the computer's memory. No new icon files are added.Testing:
--widthconfirmed on Tails. shellcheck with CI's flags reports nothing new.🤖 Generated with Claude Code
https://claude.ai/code/session_01LvEHMDeHvYQYDEkpJn95X8