Repository navigation
gui: Warn the checksum completer, not just the recoverer - #10
BenWestgate wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
|
Concept ACK |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11e2a35ff7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
A full Codex32 checksum is 13 symbols on short cards and 15 on long cards. Entering question marks for that entire suffix reaches the same low-discrimination gate as a badly damaged card, so the warning must also address someone completing a hand-written backup. Explain that earlier transcription mistakes become undetectable once the checksum is completed, and explicitly forbid replacing a failing checksum to make a card validate. Keep the route undiscoverable in the GUI, where worksheet completion is not the target workflow. Cover both 13-symbol and 15-symbol checksum-completion routes. Refs BlockstreamResearch/codex32#78 Validation: 34 GUI-reading tests passed; ruff check passed; ruff format --check passed; git diff --check passed.
11e2a35 to
8f1001f
Compare
This comment has been minimized.
This comment has been minimized.
BenWestgate
added
gate: adversarial review
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenWestgate
left a comment
BenWestgate
left a comment
There was a problem hiding this comment.
AI-generated review (Claude), posted at the maintainer's request.
1 participant
Superseded by #65 (
gui-reviewability-v1). The clean GUI rebuild contains this focused fix and its coverage:YESand that checksum replacement is not presented as a repair strategy.Keeping this older divergent GUI branch open would duplicate review and integration work. Review the behavior in #65/#66 and the eventual frozen GUI integration candidate instead.
Original scope: warn before GUI checksum completion and cover both checksum lengths.