Keep the login register link clear of the fixed footer on mobile - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The login page centered its card inside a
100vhwrapper and drew the Donate / Report Bug bar as aposition: fixedfooter with no reserved space, so on phone-sized viewports the "Don't have an account? Register" link ended up underneath the footer and could not be tapped even after scrolling to the bottom.The wrapper now uses
100dvhand reserves the footer's measured height as bottom padding, and the footer gets an explicit z-index. Proved red-then-green with a Playwright spec in B1App (ChurchApps/B1App#issue-1070) at a 390x664 viewport.ChurchApps/ChurchAppsSupport#1070