Revert "Remove podspec authors (#271)"#275
Conversation
This reverts commit 8c2518d.
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior change that removed the authors metadata from the CocoaPods podspec, restoring author attribution information for the ConstructorAutocomplete pod.
Changes:
- Restores
spec.authorsinConstructorAutocomplete.podspec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![constructor-claude-bedrock[bot]](https://avatars.githubusercontent.com/u/9828194?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This PR reverts the intentional removal of spec.authors from the podspec (PR #271), re-adding three hardcoded author email addresses.
Inline comments: 1 discussion added
Overall Assessment:
| spec.version = '4.6.1' | ||
| spec.license = { :type => 'MIT', :file => 'LICENSE' } | ||
| spec.homepage = 'https://www.constructor.io' | ||
| spec.authors = { 'Zubin Tiku' => 'zubin@constructor.io', 'Christopher Gee' => 'christopher@constructor.io', 'Jimmy Li' => 'jimmy@constructor.io' } |
There was a problem hiding this comment.
Important Issue: This reverts an intentional change made in PR #271, whose stated rationale was "Remove pod spec authors as it's already listed under maintainers in the pod trunk config". Before merging a revert, it's worth clarifying why the original decision was wrong or has changed.
Additionally, spec.authors in a CocoaPods podspec is optional metadata. Hardcoding personal email addresses here has a few practical downsides:
- Maintenance burden – Any team membership change (new hire, departure) requires a podspec update and a new release.
- Personal data exposure – Individual email addresses are embedded in every version of the published pod indefinitely.
- Redundancy – As noted in PR Remove podspec authors #271, the CocoaPods trunk config already tracks maintainers, so this field provides little additional value to consumers.
If the goal is to attribute authorship, consider using a generic team alias (e.g., 'Constructor.io' => 'mobile@constructor.io') or omitting the field entirely and relying on trunk maintainer records, as was decided in #271.
This reverts commit 8c2518d.