Skip to content

Revert "Remove podspec authors (#271)" #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HHHindawy merged 1 commit into from
May 18, 2026
Merged

Revert "Remove podspec authors (#271)" #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ConstructorAutocomplete.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Pod::Spec.new do |spec|
spec.version = '4.6.1'
spec.license = { :type => 'MIT', :file => 'LICENSE' }
spec.homepage = 'https://www.constructor.io'
spec.authors = { 'Zubin Tiku' => 'zubin@constructor.io', 'Christopher Gee' => 'christopher@constructor.io', 'Jimmy Li' => 'jimmy@constructor.io' }

@constructor-claude-bedrock constructor-claude-bedrock Bot May 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important Issue: This reverts an intentional change made in PR #271, whose stated rationale was "Remove pod spec authors as it's already listed under maintainers in the pod trunk config". Before merging a revert, it's worth clarifying why the original decision was wrong or has changed.

Additionally, spec.authors in a CocoaPods podspec is optional metadata. Hardcoding personal email addresses here has a few practical downsides:

  1. Maintenance burden – Any team membership change (new hire, departure) requires a podspec update and a new release.
  2. Personal data exposure – Individual email addresses are embedded in every version of the published pod indefinitely.
  3. Redundancy – As noted in PR Remove podspec authors #271, the CocoaPods trunk config already tracks maintainers, so this field provides little additional value to consumers.

If the goal is to attribute authorship, consider using a generic team alias (e.g., 'Constructor.io' => 'mobile@constructor.io') or omitting the field entirely and relying on trunk maintainer records, as was decided in #271.

spec.summary = 'Constructor.io iOS Client'
spec.source = { :git => 'https://github.com/Constructor-io/constructorio-client-swift.git', :tag => 'v4.6.1' }
spec.platform = :ios, '11.0'
Expand Down
Loading