Skip to content

NETCUP: fixup provider to make it pass the latest integration test suite - #4706

Merged
TomOnTime merged 7 commits into
DNSControl:release_candidate_v5from
kordianbruck:fix-netcup-v5
Aug 6, 2026
Merged

NETCUP: fixup provider to make it pass the latest integration test suite#4706
TomOnTime merged 7 commits into
DNSControl:release_candidate_v5from
kordianbruck:fix-netcup-v5

Conversation

@kordianbruck

Copy link
Copy Markdown
Contributor

This pull request introduces several improvements and fixes to the Netcup provider, focusing on better API usage, improved error handling, and stricter auditing for record compatibility. The most significant change is batching record modifications into a single API call, which streamlines updates and reduces rate limit issues. Additionally, new auditing checks are added, and the provider now verifies domain authority before returning nameservers.

Netcup Provider Improvements

  • Batch record updates: Replaces individual create, modify, and delete API calls with a single updateRecords method that batches all record changes into one API request, improving efficiency and respecting Netcup's rate limits. [1] [2]
  • API rate limiting: Introduces a 334ms delay after each API call to comply with Netcup's documented rate limit of 180 requests per minute.
  • Improved error messages: Enhances error reporting by including the action, status code, and full API response in error messages.

Record Auditing and Validation

  • New auditing rules: Adds checks to reject TXT records with backslashes, single quotes, or double quotes, and CAA records with semicolons, based on Netcup API behavior. [1] [2]
  • Test and integration updates: Updates integration tests and disables TTL-related tests for Netcup, reflecting its lack of support for custom TTLs and per-record TTLs. [1] [2]

Provider Behavior

  • Nameserver authority check: The provider now verifies domain authority with an API call before returning nameservers, ensuring accurate error handling for unmanaged domains.

dependabot Bot and others added 6 commits August 4, 2026 00:05
Bumps [ip-address](https://github.com/beaugunderson/ip-address) from 10.2.0 to 10.4.0.
- [Release notes](https://github.com/beaugunderson/ip-address/releases)
- [Commits](beaugunderson/ip-address@v10.2.0...v10.4.0)

---
updated-dependencies:
- dependency-name: ip-address
  dependency-version: 10.4.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@TomOnTime

Copy link
Copy Markdown
Collaborator

Perfect! Thanks!

@TomOnTime
TomOnTime merged commit f486bdc into DNSControl:release_candidate_v5 Aug 6, 2026
1 check passed
@kordianbruck
kordianbruck deleted the fix-netcup-v5 branch August 6, 2026 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants