NETCUP: fixup provider to make it pass the latest integration test suite - #4706
Merged
TomOnTime merged 7 commits intoAug 6, 2026
Merged
Conversation
Bumps [ip-address](https://github.com/beaugunderson/ip-address) from 10.2.0 to 10.4.0. - [Release notes](https://github.com/beaugunderson/ip-address/releases) - [Commits](beaugunderson/ip-address@v10.2.0...v10.4.0) --- updated-dependencies: - dependency-name: ip-address dependency-version: 10.4.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…es;respect rate limits of api
…d deletion logic for v5
TomOnTime
approved these changes
Aug 6, 2026
Collaborator
|
Perfect! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the Netcup provider, focusing on better API usage, improved error handling, and stricter auditing for record compatibility. The most significant change is batching record modifications into a single API call, which streamlines updates and reduces rate limit issues. Additionally, new auditing checks are added, and the provider now verifies domain authority before returning nameservers.
Netcup Provider Improvements
updateRecordsmethod that batches all record changes into one API request, improving efficiency and respecting Netcup's rate limits. [1] [2]Record Auditing and Validation
Provider Behavior