fix(deps): cap river below 0.26 on Python 3.11 - #452
Merged
Conversation
river 0.26.0's iter_csv subscripts csv.DictReader at class level, which only Python >= 3.12 supports, so importing doberman's subjective layer on 3.11 dies with 'TypeError: type DictReader is not subscriptable' the moment pip resolves the new release (the 3.11 CI leg already fails on every fresh-cache run; main is one cache miss away). Environment-marker split keeps 3.12+ on the unpinned floor.
This was referenced Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Splits the
riverdependency by Python version: 3.12+ keeps the unpinned>=0.21floor; 3.11 gets>=0.21,<0.26.Why
river 0.26.0's
stream/iter_csv.pydeclaresclass DictReader(csv.DictReader["FeatureName"])— a class-level subscript thatcsv.DictReaderonly supports on Python >= 3.12. On 3.11 the import dies withTypeError: type 'DictReader' is not subscriptable, which takes down every import ofdoberman.subjectiveand, with it, test collection for the whole suite (~230 modules, 2,860 collection errors).The 3.11 CI leg already fails on every fresh-cache run — see the red legs on #445, #446, #447 (all pre-diagnosed as unrelated to those diffs).
mainitself is one pip-cache miss away from the same failure.Root cause was diagnosed by @blackcoderx on #447 — this PR just lands the pin.
Verification
river<0.26and collects again; 3.12/3.13 stay on the current floor.Lift the cap when river ships a 3.11-safe release.