Skip to content

fix(cli): emit compact tune JSON - #462

Open
slegarraga wants to merge 2 commits into
DobermanCore:mainfrom
slegarraga:fix/tune-json-compact-contract
Open

fix(cli): emit compact tune JSON#462
slegarraga wants to merge 2 commits into
DobermanCore:mainfrom
slegarraga:fix/tune-json-compact-contract

Conversation

@slegarraga

Copy link
Copy Markdown
Contributor

Closes #431

What

  • Adds separators=(",", ":") to tune --json so it matches the compact JSON contract used by other CLI commands.
  • Adds a focused regression test that parses the output, checks proposals, and asserts neither ", " nor ": " appears.

Verification

  • .venv/bin/pytest tests/unit/test_cli_tune_json.py tests/unit/test_friction_tune.py — 24 passed.
  • .venv/bin/ruff check src tests — passed.
  • .venv/bin/ruff format --check src/doberman/cli/main.py tests/unit/test_cli_tune_json.py — passed.
  • .venv/bin/pytest tests/unit -k 'cli or friction_tune' — 258 passed, 2 skipped.

Align tune --json with the CLI machine-readable output contract and lock the compact separators in a focused regression test. Closes DobermanCore#431.
@slegarraga

Copy link
Copy Markdown
Contributor Author

Quick validation status:

  • Focused tests, full CLI/friction subset, Ruff check, and format check are green.
  • The full parallel suite also reached 91% coverage locally with 3,159 passed; its sole failure was the unrelated plugin-discovery integration case failing to import doberman from its temporary environment.
  • Remote CI: package smoke plus Ubuntu Python 3.11/3.12/3.13 are green; Windows is still running. secret-scan fails before scanning because the org-level GITLEAKS_LICENSE secret is missing, matching the pre-existing repository configuration issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cli: tune --json is the one JSON command that isn't compact

1 participant