fix(cli): align hook dry-run with installed command - #463
Open
slegarraga wants to merge 1 commit into
Open
Conversation
Import DASHBOARD_COMMAND so install and uninstall previews cannot drift from the SessionStart command written by the installer. Closes DobermanCore#429.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #429
What
DASHBOARD_COMMANDin both install and uninstall dry-run previews so the displayed SessionStart command is the same one the installer writes.doberman session-summaryand no longer mentionsdoberman dashboard.Verification
.venv/bin/pytest tests/unit/test_install_hooks.py— 44 passed..venv/bin/pytest tests/unit -k 'install_hooks or cli_help or cli_encode_safe'— 117 passed, 1 skipped..venv/bin/ruff check src tests— passed..venv/bin/ruff format --check src/doberman/cli/main.py tests/unit/test_install_hooks.py— passed.