Skip to content

test: cover data-class non-detections - #468

Open
slegarraga wants to merge 1 commit into
DobermanCore:mainfrom
slegarraga:test/data-class-nondetections
Open

test: cover data-class non-detections#468
slegarraga wants to merge 1 commit into
DobermanCore:mainfrom
slegarraga:test/data-class-nondetections

Conversation

@slegarraga

Copy link
Copy Markdown
Contributor

Closes #405

What

  • Adds regression coverage for the data-class rule's documented OTP limit: a six-digit code bound for an external destination stays PASS.
  • Adds coverage for an undashed SSA-valid SSN staying PASS, using the same digits as the valid dashed test value to prove detection depends on shape.
  • Groups both cases under a documented non-detections section beside the existing precision tests.

Verification

  • .venv/bin/pytest tests/unit/test_rule_data_classes.py -q — 16 passed.
  • .venv/bin/ruff check tests/unit/test_rule_data_classes.py — passed.
  • .venv/bin/ruff format --check tests/unit/test_rule_data_classes.py — passed.
  • git diff --check — clean.

Prove the documented OTP and undashed SSN limits stay non-detections even with an external destination. Closes DobermanCore#405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: prove the data-class rule's documented non-detections (OTP codes, undashed SSNs)

1 participant