Repository navigation
Conversation
Thread resolved enforcement through decision writers, validate pv1 IDs, and add regression coverage for invalid policy version stamps.
thesageak
marked this pull request as ready for review
October 5, 2026 07:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Slice
What this PR does
pv1:version of the effective policy snapshot used at decision time.policy_version = NULL.policy_versionthroughdoberman log --jsonlwithout exposing canonical policy contents.to_versiontopolicy-history --jsonby matching policy observations to ledger timestamps.unledgeredinpolicy-versions --verify.Tests added (run in CI)
policy_versionwithout canonical policy contents.to_version.Changelog
changelog.d/741.added.mdfragment added (one line per user-visible change, seechangelog.d/README.md), or this change is invisible to usersPublic-release safety (doberman-core only)
Security checklist
Edge cases covered / Deviations from plan / Risks introduced
NULLforpolicy_version; the schema migration intentionally does not backfill them.observed/decision, or through achangeobservation without a ledger timestamp, is reported as unledgered.ruff check .,ruff format --check ., Markdown link validation, import-linter, changelog validation, parity generation check, and the 90% coverage requirement pass.AI assistance: AI was used for design guidance and test review. All changes were reviewed and tested locally.
Closes #515