Repository navigation
Update Enzyme to 56b02e7e for OffsetViewInterface - #3373
Merged
Merged
Conversation
Update the Enzyme pin to include OffsetViewInterface and shared view-based pointer analysis from EnzymeAD/Enzyme#3420. Assisted-By: OpenAI Codex
Member
@vimarsh6739 you need to do the adapt at the same time |
Pin Enzyme to 56b02e7e94265e7af38fe95e9fbf9818ef1d09c0 from EnzymeAD/Enzyme#3420. Remove the duplicate local isCaptured implementation. Call Enzyme's helper explicitly in memory read and write checks to avoid ambiguous calls. Assisted-By: OpenAI Codex
vimarsh6739
changed the title
wsmoses
reviewed
Oct 6, 2026
| return false; | ||
| } | ||
|
|
||
| Value getBase(Value v) { |
Remove the local getBase function and use enzyme::oputils::getBaseObject in mayWriteTo and mayReadFrom. Both checks need the underlying allocation. Assisted-By: OpenAI Codex
wsmoses
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3373 +/- ##
==========================================
- Coverage 29.61% 29.61% -0.01%
==========================================
Files 239 240 +1
Lines 48403 48460 +57
==========================================
+ Hits 14336 14351 +15
- Misses 34067 34109 +42 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Enzyme from
3cd66b79ce224b8dc35cfac0e37038ed186b2013to56b02e7e94265e7af38fe95e9fbf9818ef1d09c0, the merged commit from EnzymeAD/Enzyme#3420. This providesOffsetViewInterfaceand pointer analysis through view interfaces for #2744 and #3350.The new Enzyme version exposes
isCaptured(). Enzyme-JAX's local copy makes the calls inmayWriteTo()andmayReadFrom()ambiguous. Remove the localisCaptured()andgetBase()functions. Useenzyme::oputils::isCaptured()andenzyme::oputils::getBaseObject()in both places. These checks need the underlying allocation, sogetBaseObject()uses its defaultoffsetAllowed=true.The current JAX pin already selects LLVM
018a9e4a74ba5d383351bda907a8b116bc5d8c47, which Enzyme's property assembly migration in EnzymeAD/Enzyme#3411 supports. The JAX update in #3368 selects the same LLVM revision.Validation: Clang-format 16 and whitespace checks pass for the changed code. Enzyme #3420 passed upstream MLIR debug and release CI. The full Enzyme-JAX build was not run locally; PR CI will compile and test the updated integration.