Repository navigation
deps: parse compose files with yaml_serde instead of serde_yaml_ng - #2041
Merged
Merged
Conversation
serde_yaml_ng 0.10.0 pulls in unsafe-libyaml, which RUSTSEC-2024-0449 marks as unmaintained. yaml_serde is the serde_yaml line the YAML organisation maintains (0.10.7, on libyaml-rs 0.3.0), with the same API, so only the dependency changes. I dropped the advisory from deny.toml and .cargo/audit.toml, and pointed the comments that described the old parser's behaviour at the new one after checking each claim against its source. Refs #2035 Signed-off-by: Jaro-c <75870284+Jaro-c@users.noreply.github.com>
Jaro-c
enabled auto-merge
October 13, 2026 05:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde_yaml_ng0.10.0 depends onunsafe-libyaml0.2.11, which RUSTSEC-2024-0449 marks as unmaintained. I moved the compose parser toyaml_serde0.10.7, theserde_yamlline maintained by the YAML organisation, onlibyaml-rs0.3.0. The API is the same, so the change is the dependency line, the two lockfiles, and the comments that named the old crate.serde_norway, the candidate named in #2035, has not released since 2024-12-21. The pure Rust option,serde-saphyr, has no dynamicValueand needs Rust 1.89; I left it for later in #2040.What I checked:
deny.tomland.cargo/audit.toml.cargo audit --deny warningspasses at the root and infuzz/, andcargo deny checkpasses.Eventbeingpub(crate), YAML 1.2 output) still holds foryaml_serde: its serializer differs fromserde_yaml_ng's only in imports and lifetimes. One comment said the old crate did not exposeapply_merge(), which was not true of either crate, so I reworded it.userns autotests that fail the same way on develop on this machine (its subordinate ID ranges are in use).podup configin YAML and JSON gives the same stdout, stderr and exit code in all 102 runs, including the line and column of every parse error.Closes #2035