[Fix] 0047059 UI: Use role="navigation" for LegacySlate in MainBar#11014
Merged
thibsy merged 4 commits intoILIAS-eLearning:release_11from Mar 13, 2026
Merged
[Fix] 0047059 UI: Use role="navigation" for LegacySlate in MainBar#11014thibsy merged 4 commits intoILIAS-eLearning:release_11from
thibsy merged 4 commits intoILIAS-eLearning:release_11from
Conversation
Annett7811
reviewed
Feb 13, 2026
Annett7811
left a comment
Annett7811
left a comment
There was a problem hiding this comment.
Hello!
From an accessibility perspective, this looks good. Thank you very much for your work.
Best regards,
Annett
oliversamoila
approved these changes
Feb 23, 2026
Contributor
oliversamoila
left a comment
oliversamoila
left a comment
There was a problem hiding this comment.
Hello together,
from an UX and UI perspective, the result looks good. Thank you very much for your contribution, @fhelfer.
I'm forwarding this to @thibsy for code review. He may contact you with change requests or incorporate the changes directly (That includes cherry picking too.)
Kind regards,
@oliversamoila (as UI coordinator)
thibsy
requested changes
Mar 9, 2026
Contributor
thibsy
left a comment
thibsy
left a comment
There was a problem hiding this comment.
Hi @fhelfer,
Thx a lot for your contribution to the UI framework!
Please implement the following changes:
-
roleattribute: I actually think its best to remove the attribute completely from ourMainControls\Slate\Legacycomponent, since it can hold arbitrary HTML content. Its not safe to say ifnavigationis appropriate here.
Kind regards,
@thibsy (as UI coordinator)
Contributor
Author
|
role removed for Legacy Slates |
thibsy
approved these changes
Mar 13, 2026
thibsy
pushed a commit
that referenced
this pull request
Mar 13, 2026
…te. (#11014) * Fixes https://mantis.ilias.de/view.php?id=47059 * Removes the `aria-role` attribute because we cannot safely tell what content is held by a legacy slate. Its content is of type `Component\Legacy` which holds arbitrary HTML.
thibsy
pushed a commit
that referenced
this pull request
Mar 13, 2026
…te. (#11014) * Fixes https://mantis.ilias.de/view.php?id=47059 * Removes the `aria-role` attribute because we cannot safely tell what content is held by a legacy slate. Its content is of type `Component\Legacy` which holds arbitrary HTML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error: An “li” element that is a descendant of a “role=menu” element or “role=menubar” element must not have any “role” value other than “group”, “menuitem”, “menuitemcheckbox”, “menuitemradio”, or “separator”.
https://mantis.ilias.de/view.php?id=47059
ARIA forbids role="treeitem" inside role="menu". For LegacySlates
(e.g. tree tools) use role="navigation" instead of "menu". Add
NAVIGATION to allowed Slate ARIA roles and set it in Renderer when
entry is LegacySlate. Adjust MainBarTest for LegacySlate expectation.
Problem
<li role="treeitem">innerhalb vonrole="menu"ist ungültig (z. B. Tree-Tools in der MainBar).Lösung