chore: restore original Next-steps footer in release.sh#64
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (3)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="scripts/release.sh">
<violation number="1" location="scripts/release.sh:67">
P1: The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| echo "2. git push origin v$VERSION" | ||
| echo "3. Create a PR to merge '$BRANCH' into main" | ||
| echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'" | ||
| echo "4. After merge, push the tag: git push origin v$VERSION" | ||
| echo "5. Check GitHub Actions for the Release process." |
There was a problem hiding this comment.
P1: The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/release.sh, line 67:
<comment>The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.</comment>
<file context>
@@ -63,7 +63,9 @@ git tag "v$VERSION"
-echo "3. After merge, push the tag: git push origin v$VERSION"
-echo "4. Check GitHub Actions for the Release process."
+echo "1. git push origin $BRANCH"
+echo "2. git push origin v$VERSION"
+echo "3. Create a PR to merge '$BRANCH' into main"
+echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
</file context>
| echo "2. git push origin v$VERSION" | |
| echo "3. Create a PR to merge '$BRANCH' into main" | |
| echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'" | |
| echo "4. After merge, push the tag: git push origin v$VERSION" | |
| echo "5. Check GitHub Actions for the Release process." | |
| echo "2. Create a PR to merge '$BRANCH' into main" | |
| echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'" | |
| echo "3. After merge, push the tag: git push origin v$VERSION" | |
| echo "4. Check GitHub Actions for the Release process." |
Summary
Summary by cubic
Restored the original “Next steps” footer in
scripts/release.shto match our release flow and remove the-uflag. It now prompts to push the branch, push the tag, create a PR into main withgh pr create, push the tag after merge, and check GitHub Actions.Written for commit ddc8757. Summary will update on new commits.