Skip to content

chore: restore original Next-steps footer in release.sh#64

Merged
Jamkris merged 1 commit into
mainfrom
chore/release-guard
May 12, 2026
Merged

chore: restore original Next-steps footer in release.sh#64
Jamkris merged 1 commit into
mainfrom
chore/release-guard

Conversation

@Jamkris
Copy link
Copy Markdown
Owner

@Jamkris Jamkris commented May 12, 2026

Summary


Summary by cubic

Restored the original “Next steps” footer in scripts/release.sh to match our release flow and remove the -u flag. It now prompts to push the branch, push the tag, create a PR into main with gh pr create, push the tag after merge, and check GitHub Actions.

Written for commit ddc8757. Summary will update on new commits.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (3)
  • bump version
  • release
  • chore: bump

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8d694347-dbbd-4bec-a2c9-42b7e386b486

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/release-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="scripts/release.sh">

<violation number="1" location="scripts/release.sh:67">
P1: The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Comment thread scripts/release.sh
Comment on lines +67 to +71
echo "2. git push origin v$VERSION"
echo "3. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "4. After merge, push the tag: git push origin v$VERSION"
echo "5. Check GitHub Actions for the Release process."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/release.sh, line 67:

<comment>The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.</comment>

<file context>
@@ -63,7 +63,9 @@ git tag "v$VERSION"
-echo "3. After merge, push the tag: git push origin v$VERSION"
-echo "4. Check GitHub Actions for the Release process."
+echo "1. git push origin $BRANCH"
+echo "2. git push origin v$VERSION"
+echo "3. Create a PR to merge '$BRANCH' into main"
+echo "   gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
</file context>
Suggested change
echo "2. git push origin v$VERSION"
echo "3. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "4. After merge, push the tag: git push origin v$VERSION"
echo "5. Check GitHub Actions for the Release process."
echo "2. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "3. After merge, push the tag: git push origin v$VERSION"
echo "4. Check GitHub Actions for the Release process."

@Jamkris Jamkris merged commit 6d86b75 into main May 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant