Skip to content

chore: restore original Next-steps footer in release.sh #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jamkris merged 1 commit into from
May 12, 2026
Merged

chore: restore original Next-steps footer in release.sh #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ git tag "v$VERSION"

echo "Done!"
echo "Next steps:"
echo "1. git push -u origin $BRANCH"
echo "2. gh pr create --title \"chore: release v$VERSION\" --body \"Bump version to $VERSION\""
echo "3. After merge, push the tag: git push origin v$VERSION"
echo "4. Check GitHub Actions for the Release process."
echo "1. git push origin $BRANCH"
echo "2. git push origin v$VERSION"
echo "3. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "4. After merge, push the tag: git push origin v$VERSION"
echo "5. Check GitHub Actions for the Release process."
Comment on lines +67 to +71
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At scripts/release.sh, line 67:

<comment>The next-step instructions tell users to push the release tag before merge and then again after merge. Remove the pre-merge tag push so the flow matches the intended PR-first release process.</comment>

<file context>
@@ -63,7 +63,9 @@ git tag "v$VERSION"
-echo "3. After merge, push the tag: git push origin v$VERSION"
-echo "4. Check GitHub Actions for the Release process."
+echo "1. git push origin $BRANCH"
+echo "2. git push origin v$VERSION"
+echo "3. Create a PR to merge '$BRANCH' into main"
+echo "   gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
</file context>
Suggested change
echo "2. git push origin v$VERSION"
echo "3. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "4. After merge, push the tag: git push origin v$VERSION"
echo "5. Check GitHub Actions for the Release process."
echo "2. Create a PR to merge '$BRANCH' into main"
echo " gh pr create --title 'chore: release v$VERSION' --body 'Bump version to $VERSION'"
echo "3. After merge, push the tag: git push origin v$VERSION"
echo "4. Check GitHub Actions for the Release process."

Loading