fix: validate redirect URL in auth flow to prevent open redirect#975
Closed
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Closed
fix: validate redirect URL in auth flow to prevent open redirect#975LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
LikiosSedo wants to merge 1 commit intoMODSetter:devfrom
Conversation
Reject absolute URLs, protocol-relative URLs, and scheme injections in the stored redirect path. Only allow same-origin relative paths. Closes MODSetter#949
|
@LikiosSedo is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel. A member of the Team first needs to authorize it. |
![recurseml[bot]](https://avatars.githubusercontent.com/in/1054195?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by RecurseML
🔍 Review performed on a474c46..38bad05
✨ No bugs found, your code is sparkling clean
✅ Files analyzed, no issues (1)
• surfsense_web/lib/auth-utils.ts
Owner
|
@LikiosSedo Our auth is on the backend, which is on a separate URL/domain. This will block that. Let's not add this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isValidRedirectPath()validation inauth-utils.tsto ensure redirect URLs are relative paths, preventing open redirect attacks/, has no protocol/authority, and doesn't use//prefixTest plan
https://evil.comor//evil.comare rejectedHigh-level PR Summary
This PR adds validation to the authentication redirect flow to prevent open redirect vulnerabilities. A new
isValidRedirectPath()function is introduced that validates redirect URLs are safe relative paths on the same origin, rejecting absolute URLs, protocol-relative URLs (like//evil.com), and other malicious redirect attempts. The validation is integrated intogetAndClearRedirectPath()to ensure all redirects go through this security check.⏱️ Estimated Review Time: 5-15 minutes
💡 Review Order Suggestion
surfsense_web/lib/auth-utils.ts