Skip to content

fix: validate redirect URL in auth flow to prevent open redirect #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LikiosSedo wants to merge 1 commit into from
Closed

fix: validate redirect URL in auth flow to prevent open redirect #975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions surfsense_web/lib/auth-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,26 @@ export function getAndClearRedirectPath(): string | null {
if (redirectPath) {
localStorage.removeItem(REDIRECT_PATH_KEY);
}
if (redirectPath && !isValidRedirectPath(redirectPath)) {
return null;
}
return redirectPath;
}

/**
* Validates that a redirect path is a safe, relative URL on the same origin.
* Rejects absolute URLs, protocol-relative URLs, and scheme injections.
*/
function isValidRedirectPath(path: string): boolean {
if (!path.startsWith("/") || path.startsWith("//")) return false;
try {
const url = new URL(path, window.location.origin);
return url.origin === window.location.origin;
} catch {
return false;
}
}

/**
* Gets the bearer token from localStorage
*/
Expand Down
Loading