Skip to content

remove unused fragments from input during multiplexing#801

Merged
mschwoer merged 1 commit into
mainfrom
fix-multiplexing-libraries
Jun 29, 2026
Merged

remove unused fragments from input during multiplexing#801
mschwoer merged 1 commit into
mainfrom
fix-multiplexing-libraries

Conversation

@mschwoer

@mschwoer mschwoer commented Mar 4, 2026

Copy link
Copy Markdown
Collaborator

fixes

  File "/fs/gpfs41/lv07/fileset03/home/b_mann/eikmeier/miniforge3/envs/alphadia/lib/python3.10/site-packages/alphadia/libtransform/multiplex.py", line 79, in forward
    speclib = reduce(lambda x, y: apply_func(x, y), channel_lib_list)
  File "/fs/gpfs41/lv07/fileset03/home/b_mann/eikmeier/miniforge3/envs/alphadia/lib/python3.10/site-packages/alphadia/libtransform/multiplex.py", line 79, in <lambda>
    speclib = reduce(lambda x, y: apply_func(x, y), channel_lib_list)
  File "/fs/gpfs41/lv07/fileset03/home/b_mann/eikmeier/miniforge3/envs/alphadia/lib/python3.10/site-packages/alphadia/libtransform/multiplex.py", line 76, in apply_func
    x.append(y)
  File "/fs/gpfs41/lv07/fileset03/home/b_mann/eikmeier/miniforge3/envs/alphadia/lib/python3.10/site-packages/alphabase/spectral_library/base.py", line 281, in append
    raise ValueError(
ValueError: The libraries can't be appended as the number of fragments in the current libraries are not the same.

@mschwoer mschwoer requested a review from GeorgWa March 4, 2026 08:27

@GeorgWa GeorgWa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

input.precursor_df = input.precursor_df[
input.precursor_df["channel"] == self._input_channel
]
input.remove_unused_fragments()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should always be safe to call. I'm still a bit surprised it's needed.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, do you think it's worth digging a bit deeper? maybe this is just the symptomatic cure for a more severe bug?

@mschwoer mschwoer merged commit 63fb6d1 into main Jun 29, 2026
7 checks passed
@mschwoer mschwoer deleted the fix-multiplexing-libraries branch June 29, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants