refactor(tron-wallet-snap): organize handlers and rename asset reader functions by ulissesferreira · Pull Request #90 · MetaMask/internal-snaps

ulissesferreira · 2026-07-31T21:37:55Z

Summary

Move handlers into dedicated folders (handlers/assets/, cronjob/, keyring/, user-input/) with explicit import paths

Old	New

Rename AssetsService account readers: getAccountAssets, getAccountAssetsByIDs, getAccountAssetByID
No runtime behavior change

Jira

WPN-1497 — Stage 0→1 prep (shared spine)
Parent: WPN-1478

Test plan

yarn workspace @metamask/tron-wallet-snap build
yarn workspace @metamask/tron-wallet-snap run test

Part of the AssetsController migration split stack (Step 1/3).

socket-security · 2026-08-02T20:48:24Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Pure organizational move with import path updates only. No AssetsService API renames or behavior changes.

Align public reader names with the final AssetsController-oriented API: getAccountAssets, getAccountAssetsByIDs, getAccountAssetByID.

Handler folder move requires importing from ../cronjob/cronjob rather than the bare folder path so the Snap bundle resolves correctly.

Handler files moved into subfolders in WPN-1497, so point eslint suppressions at the new paths and refresh snap.manifest.json after the handler import path fix changed the bundle hash.

ulissesferreira · 2026-08-03T13:49:52Z

@cursoragent resolve these conflicts

cursor · 2026-08-03T13:50:01Z

Merge conflicts are resolved on WPN-1497-handlers-and-renames.

What conflicted: Only packages/tron-wallet-snap/snap.manifest.json — a shasum mismatch between this branch and main.

What I did:

Merged origin/main into the branch
Resolved the manifest conflict by rebuilding the snap (ENVIRONMENT=production with .env.example values)
The build updated the shasum to 9vYQY+HG5oHsXriNEPUWw2FbLO/b4iKuf8IsUIE4QtM=
Verified tests pass locally
Committed and pushed the merge (10081da4)

main is now fully merged into this branch, so the PR should no longer show conflicts. CI will re-run on the new commit.

Resolve snap.manifest.json shasum conflict by rebuilding after merge. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

ulissesferreira · 2026-08-03T13:56:32Z

@cursoragent now there are linting problems. fix those but make sure that doesn't introduce the same shasum problem

cursor · 2026-08-03T13:56:42Z

The CI failures weren’t ESLint issues — all lint jobs passed. The Build and Test jobs failed because snap.manifest.json had the wrong shasum, leaving the working tree dirty after yarn build.

Root cause: The merge-resolution build used local .env.example URLs, but CI builds with ENVIRONMENT=production and GitHub Actions secrets for mainnet RPC URLs. Those produce a different bundle hash:

Source	Shasum
Local build (`.env.example`)	`9vYQY+HG5oHsXriNEPUWw2FbLO/b4iKuf8IsUIE4QtM=`
CI production build	`0E86PeuwFcabw+zj98vn+O/XML6E9aDeng1o7+Qq47s=`

Fix: Updated the manifest to the CI-reported shasum (0E86PeuwFcabw+zj98vn+O/XML6E9aDeng1o7+Qq47s=) without running a local production build, so we don’t overwrite it with the wrong value again.

Verified yarn lint still passes and doesn’t touch the manifest. Pushed in f7323ec4 — CI should pass once it re-runs.

…build The previous shasum was computed locally with .env.example URLs, which differs from the CI production environment secrets. Use the shasum reported by the CI build job to keep the working tree clean. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

taran-a

LGTM. GG.

Part of the AssetsController migration split stack (Step 1/3).

@ulissesferreira ^^ this is nice. I don't know if you have plans to also add links for the following PRs (would be nice imo), but the idea of stacks is really nice. We might even consider some template for such PRs if we are going to use stacks later.

ulissesferreira requested a review from a team as a code owner July 31, 2026 21:37

ulissesferreira mentioned this pull request Jul 31, 2026

refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic #91

Open

2 tasks

ulissesferreira temporarily deployed to default-branch July 31, 2026 21:38 — with GitHub Actions Inactive

ulissesferreira added the no-changelog label Jul 31, 2026

ulissesferreira requested a review from a team as a code owner July 31, 2026 21:48

ulissesferreira changed the title ~~refactor(tron-wallet-snap): organize handlers and rename asset readers (WPN-1497)~~ refactor(tron-wallet-snap): organize handlers and rename asset reader functions Jul 31, 2026

This was referenced Aug 2, 2026

[FEATURE FLAG] feat: migrate assets domain to use the AssetsController #77

Closed

[NO FEATURE FLAG] feat: migrate assets domain to use the AssetsController #78

Closed

ulissesferreira force-pushed the WPN-1497-handlers-and-renames branch from 2960d5a to 414cba1 Compare August 2, 2026 20:48

ulissesferreira changed the base branch from main to WPN-1784-shared-assets-service August 2, 2026 20:48

ulissesferreira added 4 commits August 3, 2026 00:19

refactor(tron-wallet-snap): move handlers into dedicated folders

2503949

Pure organizational move with import path updates only. No AssetsService API renames or behavior changes.

refactor(tron-wallet-snap): rename AssetsService account asset readers

dab03e9

Align public reader names with the final AssetsController-oriented API: getAccountAssets, getAccountAssetsByIDs, getAccountAssetByID.

fix(tron-wallet-snap): use explicit cronjob handler import path

990cbb5

Handler folder move requires importing from ../cronjob/cronjob rather than the bare folder path so the Snap bundle resolves correctly.

fix(tron-wallet-snap): update eslint suppressions and manifest shasum

0e17e41

Handler files moved into subfolders in WPN-1497, so point eslint suppressions at the new paths and refresh snap.manifest.json after the handler import path fix changed the bundle hash.

ulissesferreira changed the base branch from WPN-1784-shared-assets-service to main August 2, 2026 23:20

ulissesferreira force-pushed the WPN-1497-handlers-and-renames branch from 414cba1 to 0e17e41 Compare August 2, 2026 23:20

fix(tron-wallet-snap): update manifest shasum for Linux CI build

ea2e7f8

ulissesferreira mentioned this pull request Aug 2, 2026

feat(tron-wallet-snap): remove assets migration feature-flag routing #97

Draft

2 tasks

ulissesferreira enabled auto-merge August 3, 2026 13:02

Merge origin/main into WPN-1497-handlers-and-renames

10081da

Resolve snap.manifest.json shasum conflict by rebuilding after merge. Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

taran-a approved these changes Aug 3, 2026

View reviewed changes

ulissesferreira added this pull request to the merge queue Aug 3, 2026

Merged via the queue into main with commit d153bee Aug 3, 2026
46 checks passed

ulissesferreira deleted the WPN-1497-handlers-and-renames branch August 3, 2026 14:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor(tron-wallet-snap): organize handlers and rename asset reader functions - #90

refactor(tron-wallet-snap): organize handlers and rename asset reader functions#90
ulissesferreira merged 7 commits into
mainfrom
WPN-1497-handlers-and-renames

ulissesferreira commented Jul 31, 2026 •

edited

Loading

Uh oh!

socket-security Bot commented Aug 2, 2026 •

edited

Loading

Uh oh!

ulissesferreira commented Aug 3, 2026

Uh oh!

cursor Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

ulissesferreira commented Aug 3, 2026

Uh oh!

cursor Bot commented Aug 3, 2026 •

edited

Loading

Uh oh!

taran-a left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ulissesferreira commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Jira

Test plan

Uh oh!

socket-security Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulissesferreira commented Aug 3, 2026

Uh oh!

cursor Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ulissesferreira commented Aug 3, 2026

Uh oh!

cursor Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taran-a left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ulissesferreira commented Jul 31, 2026 •

edited

Loading

socket-security Bot commented Aug 2, 2026 •

edited

Loading

cursor Bot commented Aug 3, 2026 •

edited

Loading

cursor Bot commented Aug 3, 2026 •

edited

Loading