refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic by ulissesferreira · Pull Request #91 · MetaMask/internal-snaps

ulissesferreira · 2026-07-31T21:37:58Z

Summary

Extract legacy assets logic into adapters/SnapAssetsAdapter.ts
Replace AssetsService with a thin facade that delegates all public methods to the snap adapter

Jira

WPN-1497 — Stage 0→1 prep (shared spine)
Parent: WPN-1478

Test plan

yarn workspace @metamask/tron-wallet-snap build
yarn workspace @metamask/tron-wallet-snap run test

Stacks on #90 (Step 2/3).

ulissesferreira · 2026-08-04T07:29:37Z

@cursoragent rebase with latest main

cursor · 2026-08-04T07:29:43Z

Rebased onto latest main and fixed the follow-up CI issue.

Rebase

Rebased WPN-1497-snap-adapter onto origin/main (27aa57bc — feat: tron v2 feat: tron v2 #56)
Resolved conflicts in packages/tron-wallet-snap/snap.manifest.json during rebase
Force-pushed the rebased branch

Shasum fix

After the rebase, CI failed on the manifest shasum (same issue as before — Linux CI uses secret mainnet RPC URLs). Updated to the CI-expected value:

d+4EA5VWJknz8ahgtwMFrhFIp/RohdmBbKWZmc5IeYo=

Verification

yarn lint — passed
yarn workspace @metamask/tron-wallet-snap run test — passed

PR #91: #91

ulissesferreira · 2026-08-04T10:06:45Z

@cursoragent rebase latest main resolving conflicts, lint and update shasum

cursor · 2026-08-04T10:06:54Z

Rebased onto latest main, resolved conflicts, linted, and updated the manifest shasum.

Rebase

Rebased WPN-1497-snap-adapter onto origin/main (b1440657 — fix: replace computed Network enum initialisers with string literals fix: replace computed Network enum initialisers with string literals #101)
Resolved conflicts in packages/tron-wallet-snap/snap.manifest.json (shasum conflicts in two commits)
Force-pushed the rebased branch

Shasum

Linux CI uses secret mainnet RPC URLs, so the local shasum (SNtdYF0JkH5ubXZTB4QQnEow8OrOwBBAeXEr7YDtWxA=) did not match CI. Updated to the CI-expected value from the failed build job:

TEEXgH0mFwQ1x70iGzw0kNN7P/lPzIiLa+ATCM2v/vY=

Verification

yarn lint — passed
yarn workspace @metamask/tron-wallet-snap run test — passed
CI — build, lint, and all test jobs green (including tron-wallet-snap on Node 20.x and 22.x)

PR #91: #91

gabrieledm · 2026-08-04T11:09:45Z

Few comments:

Are we sure about to discard the comments from github-advanced-security with WONT_FIX ?
Are we sure the file packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts is not needed ?
- Or is it planned to add iit in another PR ?

ulissesferreira · 2026-08-04T11:39:57Z

Few comments:

* Are we sure about to discard the comments from `github-advanced-security` with `WONT_FIX` ?

* Are we sure the file `packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts` is not needed ?
  
  * Or is it planned to add iit in another PR ?

github-advanced-security > yes because the code is already existing one and we want minimal changes during the migration to the new logic. I guess we only got notified of them because it was detected as changes. But we want to move as little as possible.

packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts - hmmm I see what you mean, it's kinda useless right? Well it will be changes in one of the follow up PRs

gabrieledm · 2026-08-04T16:01:14Z

github-advanced-security > yes because the code is already existing one and we want minimal changes during the migration to the new logic. I guess we only got notified of them because it was detected as changes. But we want to move as little as possible.

packages/tron-wallet-snap/src/services/assets/adapters/SnapAssetsAdapter.test.ts - hmmm I see what you mean, it's kinda useless right? Well it will be changes in one of the follow up PRs

Makes sense.
Happy to give a review for the additional PRs

ulissesferreira · 2026-08-04T16:07:02Z

@cursoragent rebase with latest main, make sure lint is good and then babysit the PR until green

cursor · 2026-08-04T16:07:09Z

Rebased onto latest main, lint passed, and CI is green on PR #91.

Rebase

Rebased onto origin/main (69a28dea — chore: solana wallet snap integrate packages chore: solana wallet snap integrate packages #72), which also includes fix(tron-wallet-snap): stop wrapping submitRequest response in v1 KeyringResponse envelope #105 and Release/4.0.0 #106
Resolved snap.manifest.json shasum conflicts during rebase
Ran yarn install after the solana package integration (new workspace dependencies)
Force-pushed the rebased branch

Lint & tests

yarn lint — passed
yarn workspace @metamask/tron-wallet-snap run test — passed

Shasum

Linux CI uses secret mainnet RPC URLs, so the local value did not match. Updated to the CI-expected value:

uocZF1RsEzCWGmRM3X3mMv42laNfJWpwVXOfNViikl8=

CI status — green

All 49 checks passed (0 failed), including:

Build (24.x)
All lint jobs
All test jobs (bitcoin, solana, snap-networks-utils, tron-wallet-snap on Node 20.x and 22.x)
Security scans (CodeQL, Semgrep, zizmor)
Main / All jobs pass (required)

PR is mergeable (mergeable: true). mergeable_state: blocked is likely from review/approval requirements, not CI.

PR #91: #91

…rvice Move existing assets logic into SnapAssetsAdapter and keep AssetsService as a thin facade that always delegates to the Snap adapter. Behavior unchanged; prepares for a later Core adapter / feature-flag routing PR.

Adapter lives one directory deeper than AssetsService; bump client, constants, and types imports to ../../../ and ../types respectively.

Update the manifest shasum, cover AssetsService facade delegation in tests, and use SnapAssetsAdapter.isFiat inside the adapter implementation.

Move import suppressions to SnapAssetsAdapter and align test assertions with jest prefer-strict-equal rules.

Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

## Explanation This PR updates the Stellar transaction simulation layer to not require an envelope memo for self-payments / self path-payments even when the involved account has memo_required set (SEP-29), aligning memo enforcement with inbound transfers from other accounts.  ## References  ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

ulissesferreira requested a review from a team as a code owner July 31, 2026 21:37

ulissesferreira mentioned this pull request Jul 31, 2026

refactor(tron-wallet-snap): rename SNAP_SPECIAL_ASSETS to SNAP_OWNED_ASSETS #92

Merged

2 tasks

ulissesferreira added the no-changelog label Jul 31, 2026

ulissesferreira force-pushed the WPN-1497-snap-adapter branch from 53be776 to b517134 Compare July 31, 2026 21:54

github-advanced-security AI found potential problems Jul 31, 2026

View reviewed changes

ulissesferreira changed the title ~~refactor(tron-wallet-snap): extract SnapAssetsAdapter behind AssetsService (WPN-1497)~~ refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic Jul 31, 2026

ulissesferreira requested a review from a team as a code owner July 31, 2026 22:01

ulissesferreira marked this pull request as draft August 2, 2026 17:39

ulissesferreira force-pushed the WPN-1497-handlers-and-renames branch from 2960d5a to 414cba1 Compare August 2, 2026 20:48

ulissesferreira force-pushed the WPN-1497-snap-adapter branch 2 times, most recently from 8b77a78 to 30a99f6 Compare August 2, 2026 23:20

ulissesferreira force-pushed the WPN-1497-handlers-and-renames branch from 414cba1 to 0e17e41 Compare August 2, 2026 23:20

ulissesferreira mentioned this pull request Aug 2, 2026

feat(tron-wallet-snap): remove assets migration feature-flag routing #97

Draft

2 tasks

Base automatically changed from WPN-1497-handlers-and-renames to main August 3, 2026 14:53

ulissesferreira marked this pull request as ready for review August 3, 2026 15:06

ulissesferreira temporarily deployed to default-branch August 3, 2026 15:06 — with GitHub Actions Inactive

cursor Bot force-pushed the WPN-1497-snap-adapter branch from 30a99f6 to 4e73383 Compare August 3, 2026 15:09

MetaMask deleted a comment from cursor Bot Aug 4, 2026

cursor Bot force-pushed the WPN-1497-snap-adapter branch from a6cbab4 to e34f69c Compare August 4, 2026 07:44

cursor Bot force-pushed the WPN-1497-snap-adapter branch from da939f6 to cb7a717 Compare August 4, 2026 10:12

ulissesferreira enabled auto-merge August 4, 2026 12:29

ulissesferreira force-pushed the WPN-1497-snap-adapter branch from 5e27de9 to 9532cbd Compare August 4, 2026 13:45

gabrieledm previously approved these changes Aug 4, 2026

View reviewed changes

cursor Bot dismissed gabrieledm’s stale review via 7ac16ca August 4, 2026 16:09

cursor Bot force-pushed the WPN-1497-snap-adapter branch from 9532cbd to 7ac16ca Compare August 4, 2026 16:09

ulissesferreira and others added 7 commits August 4, 2026 16:22

fix(tron-wallet-snap): correct SnapAssetsAdapter relative import paths

cfe9be2

Adapter lives one directory deeper than AssetsService; bump client, constants, and types imports to ../../../ and ../types respectively.

fix(tron-wallet-snap): restore CI after SnapAssetsAdapter extraction

147ee4b

Update the manifest shasum, cover AssetsService facade delegation in tests, and use SnapAssetsAdapter.isFiat inside the adapter implementation.

style(tron-wallet-snap): format AssetsService facade

7b24d5b

fix(tron-wallet-snap): satisfy eslint for facade delegation tests

c905d7c

Move import suppressions to SnapAssetsAdapter and align test assertions with jest prefer-strict-equal rules.

style(tron-wallet-snap): format facade delegation test

8c54c71

fix(tron-wallet-snap): update manifest shasum after rebase onto main

772082a

Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

cursor Bot force-pushed the WPN-1497-snap-adapter branch from a122613 to 772082a Compare August 4, 2026 16:23

fix(tron-wallet-snap): update manifest shasum for Linux CI build

bb57b83

Co-authored-by: Ulisses Ferreira <ulisses@hey.com>

gabrieledm approved these changes Aug 4, 2026

View reviewed changes

ulissesferreira added this pull request to the merge queue Aug 4, 2026

Merged via the queue into main with commit be07f23 Aug 4, 2026
49 checks passed

ulissesferreira deleted the WPN-1497-snap-adapter branch August 4, 2026 21:08

This was referenced Aug 5, 2026

fix: disclose WitnessCreateContract 9,999 TRX burn fee (WPN-1719) #73

Merged

feat(tron-wallet-snap): add Core messenger plumbing #95

Open

ulissesferreira mentioned this pull request Aug 5, 2026

refactor(WPN-1652): extract SnapAssetsAdapter for Solana balance reads #121

Draft

4 tasks

cursor Bot mentioned this pull request Aug 5, 2026

feat(WPN-1486): remove Solana Snap assets tracking after flag migration #125

Draft

4 tasks

Navigation Menu

Uh oh!

refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic - #91

refactor(tron-wallet-snap): extract SnapAssetsAdapter from existing AssetsService logic#91
ulissesferreira merged 8 commits into
mainfrom
WPN-1497-snap-adapter

ulissesferreira commented Jul 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

gabrieledm commented Aug 4, 2026

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

gabrieledm commented Aug 4, 2026

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ulissesferreira commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Jira

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rebase

Shasum fix

Verification

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rebase

Shasum

Verification

Uh oh!

gabrieledm commented Aug 4, 2026

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

gabrieledm commented Aug 4, 2026

Uh oh!

ulissesferreira commented Aug 4, 2026

Uh oh!

cursor Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rebase

Lint & tests

Shasum

CI status — green

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ulissesferreira commented Jul 31, 2026 •

edited

Loading

cursor Bot commented Aug 4, 2026 •

edited

Loading

cursor Bot commented Aug 4, 2026 •

edited

Loading

cursor Bot commented Aug 4, 2026 •

edited

Loading