chore: solana wallet snap integrate packages - #72
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Battambang
changed the title
Battambang
added a commit
that referenced
this pull request
Jul 30, 2026
Satisfy the Check changelog CI requirement that Unreleased entries reference the current pull request.
Contributor
Author
|
@SocketSecurity ignore npm/@types/express-serve-static-core@5.1.2 package used in |
Contributor
Author
|
@SocketSecurity ignore npm/glob@13.0.6 package used in |
Contributor
Author
|
@SocketSecurity ignore npm/@solana/rpc-transport-http@2.1.0 socket.dev security reporting has all security metrics very high score confidence (all metrics green >96) |
Contributor
Author
|
@SocketSecurity ignore npm/@solana-program/compute-budget@0.7.0 socket.dev is showing the solana-devs author group with several package score confidence. |
Contributor
Author
|
@SocketSecurity ignore npm/@solana/rpc-transport-http@2.3.0 socket.dev security reporting has all security metrics very high score confidence (all metrics green >96) |
Contributor
Author
|
@SocketSecurity ignore npm/@solana-program/system@0.7.0 socket.dev is showing the solana-devs author group with several package score confidence. |
Battambang
force-pushed
the
chore/solana-wallet-snap-integrate-packages
branch
from
July 30, 2026 17:06
c968237 to
fecb49a
Compare
Battambang
added a commit
that referenced
this pull request
Jul 30, 2026
Link the Unreleased entry to #72 so Check changelog passes for the collateral bitcoin-wallet-snap change.
Battambang
marked this pull request as ready for review
July 30, 2026 17:44
Battambang
temporarily deployed
to
default-branch
July 30, 2026 17:45 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Battambang
commented
Jul 30, 2026
Place the snap under packages/ so Yarn workspaces can resolve it, and update yarn.lock for the new workspace dependencies.
Match description, keywords, and test scripts to the monorepo workspace constraints used by the other snaps.
Bump concurrently, dotenv, @metamask/superstruct, and bignumber.js to match bitcoin-/tron-wallet-snap and clear yarn constraints mismatches. Refresh snap.manifest.json after rebuild (shasum, repository, platformVersion).
Match bitcoin-/tron-wallet-snap exact ranges (11.1.1 and 2.0.0) so yarn constraints version consistency passes for these deps.
Bump root @types/lodash to ^4.17.15 so yarn constraints version consistency matches the Solana workspace declaration.
Align rimraf to ^6.0.1 across workspaces that declare it so yarn constraints version consistency passes and installs a single v6.
Narrow @metamask/snaps-cli to ^8.3.0 so yarn constraints version consistency matches bitcoin-/tron-/sample-snap (still resolves to 8.4.1).
Bump snaps-cli, snaps-sdk, superstruct, keyring-api, and keyring-snap-sdk declarations to match bitcoin-/tron-wallet-snap after #43 (installed versions unchanged).
Align @metamask/key-tree to ^10.1.1 with bitcoin-/tron-wallet-snap so yarn constraints pass.
Absorb existing Solana snap lint findings into eslint-suppressions.json, and apply minor autofixes from eslint --fix.
Assign @MetaMask/networks as owners for packages/solana-wallet-snap, matching bitcoin- and tron-wallet-snap.
Update the generated packages section so readme-content:check passes with the new workspace.
Collapse ignore, minipass, and package-json-from-dist to their highest resolved versions so yarn dedupe --check passes in CI.
Satisfy the Check changelog CI requirement that Unreleased entries reference the current pull request.
Treat Infura-keyed mainnet/devnet RPC and websocket URLs as secrets; keep public testnet, localnet, and explorer URLs as repository vars.
Update solana and bitcoin shasums so yarn build leaves a clean tree in CI (bitcoin drifts due to shared yarn.lock changes).
Avoid parallel workers colliding on the mock RPC port 8899 in CI, matching the source snap-solana-wallet test script.
Keep the monorepo-required test script string, and run Solana tests serially in jest.config to avoid mock RPC port 8899 collisions.
Match bitcoin-/tron-/sample-snap after #75: split LICENSE.MIT / LICENSE.APACHE2 and set package.json license to (MIT OR Apache-2.0).
Override production for Solana test matrix builds so snaps-jest gets dev permissions, matching the source snap CI. Restore the production snap.manifest shasum before the dirty-tree check.
<!-- Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: * What is the current state of things and why does it need to change? * What is the solution your changes offer and how does it work? * Are there any changes whose purpose might not obvious to those unfamiliar with the domain? * If your primary goal was to update one package but you found you had to update another one along the way, why did you do so? * If you had to upgrade a dependency, why did you do so? --> Skip tests which use `installSnap` and external API calls. Revert `lint-build-test.yml` to use common setup. <!-- Are there any issues that this pull request is tied to? Are there other links that reviewers should consult to understand these changes better? Are there client or consumer pull requests to adopt any breaking changes? For example: * Fixes #12345 * Related to #67890 --> - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/internal-snaps/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them
taran-a
force-pushed
the
chore/solana-wallet-snap-integrate-packages
branch
from
August 4, 2026 15:34
5ec018c to
0917508
Compare
gabrieledm
approved these changes
Aug 4, 2026
ulissesferreira
approved these changes
Aug 4, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request integrates the Solana Wallet Snap into the monorepo, updates related configuration and documentation, and aligns dependencies and workflows to support the new package. It also includes license files for the Solana package and minor dependency updates for other packages.
Solana Wallet Snap Integration and Licensing:
@metamask/solana-wallet-snappackage to the monorepo, including its README and changelog, and updated the package list inREADME.md.LICENSE,LICENSE.APACHE2, and referencingLICENSE.MIT.Monorepo and Ownership Updates:
packages/solana-wallet-snapto.github/CODEOWNERSfor ownership tracking.CI/CD Workflow Enhancements:
lint-build-test.yml,main.yml,publish-release.yml,publish-preview.yml) to inject new Solana-related environment variables, handle Solana-specific test builds, and restore the Solana snap manifest after test builds.Dependency and Manifest Updates:
rimrafand@types/lodashdependencies in root and sample package manifests for improved compatibility and security.snap.manifest.jsonshasum for the Bitcoin Wallet Snap after aligning Solana dependencies.Changelog and Documentation: