Repository navigation
Conversation
Signed-off-by: Shiju <shiju@nvidia.com>
|
Label |
5 of 6 tasks
shiju-nv
marked this pull request as draft
November 8, 2026 19:16
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create missing fd and standard-stream links after guest proc/dev mounts. Minimal Linux guests can then run the init script's Bash process substitution without relying on the VM runtime to populate those paths.
Related Issue
Closes #5373
Changes
/dev/fd,/dev/stdin,/dev/stdoutand/dev/stderraliases before first use.Release Notes
Testing
Five focused guest-init tests and scoped all-targets Clippy passed on macOS. A separate Linux PID/mount-namespace check exercised the exact bootstrap function: the base failed at
/dev/fd/63, while the patch passed process substitution and standard-stream I/O. Seven expected outcomes covered missing and existing aliases, conflicting/dangling entries and closed streams.A fresh downstream integration build with the exact reviewed fd functions reached Ready with configuration accepted, ran authenticated exec with exit 0, and deleted successfully on both Firecracker and libkrun. The Linux ARM64/KVM host runs under QEMU TCG on this Mac; matching guest/helper inputs and the existing preparation helpers were retained.
Shell syntax, formatting and Markdown checks passed. ShellCheck reports the same existing SC2034 warning on base and patch; excluding that unchanged warning passes.
Checklist