Repository navigation
test: clear two test-only CodeQL alerts - #184
Open
chrisknvidia wants to merge 1 commit into
Open
chrisknvidia wants to merge 1 commit into
chrisknvidia wants to merge 1 commit into
Conversation
py/incomplete-url-substring-sanitization in test_provider_config.py: the no-credential test checked that "build.nvidia.com" appeared somewhere in the setup message. It now checks the exact " Get a key: https://build.nvidia.com" line, which is stricter. py/clear-text-storage-sensitive-data in test_harbor_local_sandbox.py: the bwrap host-home test wrote a value named `secret` to a file in the host home. The test only needs recognizable text to prove the sandbox cannot read that file, so the value is now a plain marker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
chrisknvidia
requested review from
mosheabr,
rmalani-nv and
rng1995
as code owners
October 6, 2026 05:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears two open CodeQL alerts on main. Both are in tests; no product code changes.
tests/test_provider_config.py): the no-credential test checked thatbuild.nvidia.comappeared somewhere in the setup message. It now checks the exactGet a key: https://build.nvidia.comline, which is stricter.tests/test_harbor_local_sandbox.py): the bwrap host-home test wrote a value namedsecretto a file in the host home. The test only needs recognizable text to prove the sandbox can't read that file, so it now writes a plain marker. The assertions are unchanged apart from the name.The three
py/redosalerts invalidators/security.pyand thetest_schema.pyalert are fixed on PR #28, which edits those files.Verified:
ruff checkand both test files pass (204 passed, 5 skipped; the bwrap tests skip on macOS and run on Linux CI).🤖 Generated with Claude Code