Skip to content

test: clear two test-only CodeQL alerts #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisknvidia wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: clear two test-only CodeQL alerts #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tests/test_harbor_local_sandbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1469,8 +1469,9 @@ def test_runtime_visible_read_only_without_unrelated_host_home_contents(self, ru

probe_dir = Path(tempfile.mkdtemp(prefix=".skilleval-host-read-probe-", dir=Path.home())).resolve()
sentinel = probe_dir / "sentinel.txt"
secret = "BWRAP-HOST-HOME-SECRET"
sentinel.write_text(secret, encoding="utf-8")
# A plain marker, not a credential: the test only needs text it can look for.
marker = "BWRAP-HOST-HOME-MARKER"
sentinel.write_text(marker, encoding="utf-8")
python_executable = Path(sys.executable).resolve()
runtime_root = python_executable.parent.parent
runtime_write_probe = runtime_root / f".skillevaluator-write-probe-{probe_dir.name}"
Expand Down Expand Up @@ -1500,8 +1501,8 @@ def test_runtime_visible_read_only_without_unrelated_host_home_contents(self, ru
try:
result = self._run([str(python_executable), "-B", "-c", code], run_root)
assert result.returncode == 0, result.stderr
assert secret not in result.stdout
assert secret not in result.stderr
assert marker not in result.stdout
assert marker not in result.stderr
finally:
runtime_write_probe.unlink(missing_ok=True)
shutil.rmtree(probe_dir, ignore_errors=True)
Expand Down
2 changes: 1 addition & 1 deletion tests/test_provider_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@ def test_no_credential_llm_error_leads_with_copyable_setup() -> None:
assert message.startswith("No provider is configured.\n\n")
assert " export SKILL_EVAL_LLM_PROVIDER=nv_build\n" in message
assert " export NVIDIA_API_KEY='your-api-key'\n" in message
assert "build.nvidia.com" in message
assert " Get a key: https://build.nvidia.com" in message.splitlines()
assert "OPENAI_API_KEY" in message
assert "ANTHROPIC_API_KEY" in message
assert "https://docs.nvidia.com/skills/skillevaluator/configuration" in message
Expand Down
Loading