Skip to content

[None][infra] Waive 2 failed cases for main in pre-merge 48918#16682

Merged
dpitman-nvda merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260721-190148
Jul 21, 2026
Merged

[None][infra] Waive 2 failed cases for main in pre-merge 48918#16682
dpitman-nvda merged 1 commit into
NVIDIA:mainfrom
trtllm-agent:trtllm-ci-report/waive-20260721-190148

Conversation

@trtllm-agent

@trtllm-agent trtllm-agent commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Auto-generated Waive PR

Created by: TensorRT LLM CI Report (requested by @tburt-nv)
Target branch: main
Bug(s): 6468821, 6488811

Waive entries added

unittest/_torch/attention/test_attention_backends.py::test_attention_backend[gpt_oss_gqa_hd64_gptj_swa128-ctx-bf16-HND-p32-v1] SKIP (https://nvbugs/6468821)
unittest/llmapi/test_llm_pytorch.py::test_llm_context_only_timed_out_kv_cache_exhausted[None-UCX-100] SKIP (https://nvbugs/6488811)

This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.

Dev Engineer Review

  • Added two SKIP entries to tests/integration/test_lists/waives.txt for the specified test parameterizations.
  • Entries include the associated bugs 6468821 and 6488811; no unintended scope changes or duplicate entries found.
  • Waiver file format and test paths are consistent.

QA Engineer Review

  • Test-list-only change; no test-db/ or qa/ files were modified.
  • Added waivers for:
    • test_attention_backend[...] (ctx-bf16)
    • test_llm_context_only_timed_out_kv_cache_exhausted[...] (UCX-100)
  • Verdict: needs follow-up — CBTS coverage data is unavailable.

Bug(s): 6468821, 6488811
Requested by: @tburt-nv

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Two parameterized integration test variants are added to tests/integration/test_lists/waives.txt as skipped cases.

Changes

Integration test waivers

Layer / File(s) Summary
Add parameterized test waivers
tests/integration/test_lists/waives.txt
Adds SKIP entries for the ctx-bf16 attention backend variant and the None-UCX-100 LLM context-only timeout variant.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description covers the waive entries and bugs, but it omits the required template sections for Description, Test Coverage, and PR Checklist. Add the template sections with a short problem/solution summary, relevant tests or rationale, and the PR checklist confirmation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states this is an infra PR waiving two failed cases and matches the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Line 397: Add the repository-standard NVIDIA copyright header to the modified
test file associated with test_attention_backend, using the current year in the
copyright notice; preserve the existing test entry unchanged.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: df5c7694-edcd-4bdf-97ea-cbb6bdb73be8

📥 Commits

Reviewing files that changed from the base of the PR and between a75e333 and 08a4c15.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

Comment thread tests/integration/test_lists/waives.txt
@tburt-nv

Copy link
Copy Markdown
Collaborator

/bot skip --comment "waive only"

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60768 [ skip ] triggered by Bot. Commit: 08a4c15 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #60768 [ skip ] completed with state SUCCESS. Commit: 08a4c15
Skipping testing for commit 08a4c15

Link to invocation

@dpitman-nvda
dpitman-nvda merged commit c988141 into NVIDIA:main Jul 21, 2026
12 checks passed
yuanjingx87 pushed a commit to yuanjingx87/TensorRT-LLM that referenced this pull request Jul 26, 2026
…A#16682)

Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants