test(nemar): drop 15 published deposits from NEMAR_ID_PENDING - #1223
Merged
bruAristimunha merged 1 commit intoOct 5, 2026
Merged
Conversation
Mark these NEMAR deposits as public and let test_all_datasets_have_valid_nemar_id assert their published ids. Each deposit was verified on 2026-10-05 against the anonymous public GitHub mirror and against one annexed EDF reachable via https://nemar.s3.us-east-2.amazonaws.com/<id>/objects/<key> (HTTP 200): nm000174 AguileraRodriguez2025 nm000252 Nguyen2017_L nm000177 Kumar2024 nm000257 Nguyen2017_S nm000178 BNCI2020_001 nm000258 Pressel2016 nm000184 BCIComp2020WalkingERP nm000261 Nguyen2017_V nm000220 Beetl2021_A nm000263 Kaneshiro2015 nm000224 Nguyen2017_SL nm000269 Mainsah2025_A nm000233 BCIComp2020UpperLimb nm000273 Lee2019_SSVEP nm000274 Beetl2021_B No loader scientific change: every one of these loaders already declares its nemar_id, so the NEMAR download provider path was already active; this change only promotes them out of the pending-publication skip list. Evidence: .pr-audits/w41/p2-evidence/anon-report.tsv (not committed).
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Drop 15 NEMAR deposits from
NEMAR_ID_PENDINGinmoabb/tests/test_datasets.pyso thattest_all_datasets_have_valid_nemar_idasserts their published ids instead of skipping them. These 15 deposits were pushed to the admin-published state and became anonymously reachable on NEMAR; the pending list ondevelopwas lagging behind reality.No loader scientific change. Every one of these 15 loaders already declared its
nemar_idondevelop, so the NEMAR download-provider path was already active for them. The only visible change is that the regex validity test now runs against these class attributes instead of being skipped. No changelog entry (test-only; please apply theno changeloglabel).Evidence
Verified from Voyager's login node on 2026-10-05, one id at a time:
nemar dataset status <id>→Status: active, confirming the deposit record.GIT_CONFIG_GLOBAL=/dev/null GIT_TERMINAL_PROMPT=0 git -c credential.helper= clone --depth 1 https://github.com/nemarDatasets/<id> /tmp/w41-anon/<id>→ success (public anonymous clone, no credentials).git annex whereis(nemar-s3 publicurl), thencurl -sI https://nemar.s3.us-east-2.amazonaws.com/<id>/objects/<key>→HTTP/1.1 200 OK.Full report:
.pr-audits/w41/p2-evidence/anon-report.tsv(local; not committed).sourcedata/.../file_downloaded.edf, 13.3 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 5.5 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 74 MB)sub-1/ses-0/eeg/..._task-p300_run-0_eeg.edf, 3.3 MB)sub-1/ses-0/eeg/..._acq-finaltest_run-1_eeg.edf, 50 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 44 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 19.8 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 44 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 66 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 29.9 MB)sub-1/ses-0/eeg/..._task-imagery_run-0_eeg.edf, 66 MB)sub-1/ses-0/eeg/..._task-p300_run-0_eeg.edf, 49 MB)sourcedata/A_01/.../A_01_SE001_CB_Test06.edf, 8.1 MB)sub-1/ses-0/eeg/..._task-ssvep_acq-train_run-1_eeg.edf, 194 MB)sub-4/ses-0/eeg/..._acq-finaltest_run-1_eeg.edf, 10.3 MB)Not in this PR
nemar dataset publish status nm000288returnedStatus: requestedand the anonymoushttps://github.com/nemarDatasets/nm000288HEAD returned 404 on 2026-10-05 — still blocked on admin publication, left pending.NEMAR_ID_PENDINGwhose publication is stillrequested/noneon NEMAR are unchanged.Tests
Local, in a fresh worktree off
origin/develop @ d7e0951:test_download_falls_back_from_nemarandtest_download_without_nemar_id_uses_fallbackfail identically with and without this patch ondevelop— they rely on a per-process download-provider state that leaks from other tests (get_download_provider() == 'nemar') and raiseNemarDownloadErrorbefore monkeypatching takes effect. Pre-existing; not touched here.