Avoid having the version spread everywhere#286
Merged
mgaffigan merged 1 commit intoApr 14, 2026
Conversation
Merged
mgaffigan
marked this pull request as ready for review
April 5, 2026 03:47
jonbartels
requested changes
Apr 6, 2026
jonbartels
self-requested a review
April 7, 2026 23:21
jonbartels
approved these changes
Apr 7, 2026
jonbartels
approved these changes
Apr 8, 2026
mgaffigan
requested review from
a team,
NicoPiel,
gibson9583,
kayyagari,
pacmano1,
ssrowe and
tonygermano
and removed request for
a team
April 14, 2026 18:11
tonygermano
approved these changes
Apr 14, 2026
tonygermano
left a comment
Member
There was a problem hiding this comment.
Looks good to me. For anyone else searching like I did, this is where the replace happens:
Lines 444 to 447 in 5203b3a
NicoPiel
approved these changes
Apr 14, 2026
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
mgaffigan
force-pushed
the
maint/avoid-versions-in-code
branch
from
April 14, 2026 21:02
00a8aeb to
cfe1e1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralizes to the existing
mirth-build.propertiesversionproperty.Shifts tests to using 99.99.99 as the version to avoid confusion.