feat: Implement FEATURE_BUNDLE_1 RFC 0004 #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
a4cabcd to
0643fb1
Compare
jericht
previously approved these changes
Jan 30, 2026
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
0643fb1 to
40e8a87
Compare
Signed-off-by: Mark <399551+mwiebe@users.noreply.github.com>
mwiebe
force-pushed
the
implement-rfc-0004
branch
from
40e8a87 to
47521c8
Compare
|
jericht
approved these changes
Feb 3, 2026
leongdl
approved these changes
Feb 3, 2026
leongdl
reviewed
Feb 3, 2026
| @@ -1,6 +1,7 @@ | |||
| # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
Contributor
There was a problem hiding this comment.
Should we build some job bundles and add them to integration testing at the openjd cli level?
Contributor
Author
There was a problem hiding this comment.
Yeah, there are a few simple ones in https://github.com/OpenJobDescription/openjd-cli/pull/204/changes, we can expand that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
RFC 4 is accepted and needs implementation
What was the solution? (How)
Update the openjd-model dependency to 0.9.* that supports FEATURE_BUNDLE_1.
Implement support for the endOfLine specification in embedded files in templates. The syntax sugar is de-sugared in openjd-models, and the limits are enforced there, so this is the only change that openjd-sessions needs to perform.
Where some model field types changed as noted in the openjd-model changelog, have commented
# type: ignore[arg-type]to accept the types as the runtime behavior there is unchanged.What is the impact of this change?
Support for OpenJD RFC 0004.
How was this change tested?
Tested together with the openjd-model and an openjd-cli change.
Was this change documented?
N/A
Is this a breaking change?
No
Does this change impact security?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.