Skip to content

SysState drops tether_induced_force and tether_induced_moment: two call sites go with them #5

Description

@1-Bort-1

KiteUtils 0.13 removes SysState.tether_induced_force and SysState.tether_induced_moment (OpenSourceAWE/KiteUtils.jl#138, in OpenSourceAWE/KiteUtils.jl#140). Nothing ever filled them here, which is why they went: Body.tether_force and Body.tether_moment are declared at src/system_structure/rigid_body.jl:103-104, but the wing readout map in src/model_management.jl syncs aero_force_b and aero_moment_b and not those two, so the value copied into the state has not moved since construction.

Two call sites break when that release lands:

  • src/symbolic_awe_model.jl:370-371 — ss.tether_induced_force .= wing.tether_force and the moment line beside it. Delete both.
  • ext/StableAWEModelsMakieExt.jl:1237-1244 — the plot_tether_moment=true panel plots sl.tether_induced_moment[i][2], which is that same constant. Removing the keyword is a user-visible change of this package, so it is yours to decide; the alternative is to plot the quantity properly, summing the spring_force entries of the segments attached to the wing.

Body.tether_force and Body.tether_moment have no writer left afterwards, so they go with the call sites unless something is meant to fill them.

Same change as OpenSourceAWE/SymbolicAWEModels.jl#323, which also carries a restore path this repo does not have.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions