Skip to content

chore(tests): use does_not in test identifiers - #1752

Open
daixiheguu wants to merge 1 commit into
OpenZeppelin:mainfrom
daixiheguu:my_feature
Open

daixiheguu wants to merge 1 commit into
OpenZeppelin:mainfrom
daixiheguu:my_feature

Conversation

@daixiheguu

@daixiheguu daixiheguu commented Aug 25, 2026 •

Copy link
Copy Markdown

Fixes #???

Normalize five internal Cairo test identifiers from doesnt to does_not across the account, ERC20, and ERC4626 test suites. This is a naming-only cleanup: test behavior, assertions, contract code, and public APIs are unchanged.

PR Checklist

  • Tests
  • Documentation
  • Added entry to CHANGELOG.md
  • Tried the feature on a public network

Summary by CodeRabbit

  • Tests
    • Improved test naming for clarity and consistency across account, token, allowance, interface-support, and reentrancy scenarios.
    • Test logic, assertions, and behavior remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c4e99de-90ab-4618-ae79-a451b4d73300

📥 Commits

Reviewing files that changed from the base of the PR and between d7c0466 and 28d264b.

📒 Files selected for processing (5)
  • packages/presets/src/tests/test_account.cairo
  • packages/presets/src/tests/test_erc20.cairo
  • packages/presets/src/tests/test_eth_account.cairo
  • packages/token/src/tests/erc20/test_erc20.cairo
  • packages/token/src/tests/erc4626/test_erc4626.cairo

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


Walkthrough

The changes rename local variables and test functions to use “does_not” wording. Test bodies, assertions, and behavior remain unchanged.

Changes

Test naming consistency

Layer / File(s) Summary
Rename test identifiers
packages/presets/src/tests/*, packages/token/src/tests/*
Account interface variables and ERC20/ERC4626 test functions now use “does_not” wording. Test logic and assertions are unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 28d26

This is a localized test-naming cleanup with no behavior or public API changes; no actionable merge-blocking risk remains after normal checks and review.

Poem

A rabbit checks each test by moonlit light
“Does not” now names the intent just right
No assertion hops, no logic strays
The same green tests greet the days
Clean names wiggle their ears tonight

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the naming-only test cleanup. It matches the main change from doesnt to does_not in test identifiers.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant