Skip to content

chore(tests): use does_not in test identifiers #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daixiheguu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(tests): use does_not in test identifiers #1752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/presets/src/tests/test_account.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,8 @@ fn test_supports_interface() {
let supports_isrc6 = dispatcher.supports_interface(ISRC6_ID);
assert!(supports_isrc6);

let doesnt_support_dummy_id = !dispatcher.supports_interface('DUMMY_INTERFACE_ID');
assert!(doesnt_support_dummy_id);
let does_not_support_dummy_id = !dispatcher.supports_interface('DUMMY_INTERFACE_ID');
assert!(does_not_support_dummy_id);
}

//
Expand Down
4 changes: 2 additions & 2 deletions packages/presets/src/tests/test_erc20.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ fn test_transfer_from() {
}

#[test]
fn test_transfer_from_doesnt_consume_infinite_allowance() {
fn test_transfer_from_does_not_consume_infinite_allowance() {
let (_, mut dispatcher) = setup_dispatcher();

start_cheat_caller_address(dispatcher.contract_address, OWNER);
Expand Down Expand Up @@ -260,7 +260,7 @@ fn test_transferFrom() {
}

#[test]
fn test_transferFrom_doesnt_consume_infinite_allowance() {
fn test_transferFrom_does_not_consume_infinite_allowance() {
let (_, mut dispatcher) = setup_dispatcher();
start_cheat_caller_address(dispatcher.contract_address, OWNER);
dispatcher.approve(SPENDER, Bounded::MAX);
Expand Down
4 changes: 2 additions & 2 deletions packages/presets/src/tests/test_eth_account.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,8 @@ fn test_supports_interface() {
let supports_isrc6 = dispatcher.supports_interface(ISRC6_ID);
assert!(supports_isrc6);

let doesnt_support_dummy_id = !dispatcher.supports_interface('DUMMY_INTERFACE_ID');
assert!(doesnt_support_dummy_id);
let does_not_support_dummy_id = !dispatcher.supports_interface('DUMMY_INTERFACE_ID');
assert!(does_not_support_dummy_id);
}

//
Expand Down
4 changes: 2 additions & 2 deletions packages/token/src/tests/erc20/test_erc20.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ fn test_transfer_from() {
}

#[test]
fn test_transfer_from_doesnt_consume_infinite_allowance() {
fn test_transfer_from_does_not_consume_infinite_allowance() {
let mut state = setup();
start_cheat_caller_address(test_address(), OWNER);
state.approve(SPENDER, Bounded::MAX);
Expand Down Expand Up @@ -341,7 +341,7 @@ fn test_transferFrom() {
}

#[test]
fn test_transferFrom_doesnt_consume_infinite_allowance() {
fn test_transferFrom_does_not_consume_infinite_allowance() {
let mut state = setup();
start_cheat_caller_address(test_address(), OWNER);
state.approve(SPENDER, Bounded::MAX);
Expand Down
4 changes: 2 additions & 2 deletions packages/token/src/tests/erc4626/test_erc4626.cairo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,7 @@ fn test_share_price_with_reentrancy_after_withdraw() {
}

#[test]
fn test_price_change_during_reentrancy_doesnt_affect_deposit() {
fn test_price_change_during_reentrancy_does_not_affect_deposit() {
let (asset, vault) = setup_reentrancy();

let value: u256 = 1_000_000_000_000_000_000;
Expand Down Expand Up @@ -1076,7 +1076,7 @@ fn test_price_change_during_reentrancy_doesnt_affect_deposit() {
}

#[test]
fn test_price_change_during_reentrancy_doesnt_affect_withdraw() {
fn test_price_change_during_reentrancy_does_not_affect_withdraw() {
let (asset, vault) = setup_reentrancy();

let value: u256 = 1_000_000_000_000_000_000;
Expand Down