Repository navigation
feat: add accessibility preferences and inline account settings - #83
Conversation
Refs PapyrusReader/docs#65. Preserve system accessibility behavior, improve shared controls, and persist guest profiles alongside private account photo uploads.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4ed0822fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Settings now provides working device-wide accessibility preferences and inline account editing, including persistent anonymous profiles and private signed-in photo uploads.
Issue and requirements
Refs PapyrusReader/docs#65 (NFR-5_2, foundation only) and FR-1_4 (offline profile isolation).
Server dependency: PapyrusReader/server#42.
Documentation and audit: PapyrusReader/docs#88.
Summary
Testing
UI evidence
The linked documentation audit records browser inspection and automated scenarios at 320, 390, and 1280 logical pixels, enlarged text, contrast variants, and keyboard behavior. Screenshots are not attached to this PR. VoiceOver, TalkBack, and complete native acceptance remain pending.
Compatibility and migration
No version bump, database migration, synchronization schema change, or reader-package change. Deploy server PR #42 before releasing this client with signed-in photo uploads. New preferences are device-local and reuse the existing font preference. Existing local reader override and lockfile changes are excluded from this commit.
Notes
This does not establish full-app accessibility conformance. Reader content and broader pages remain unaudited. Compact book-cover controls retain the existing 30-pixel targets as a documented product-target exception. Signed-in profile saves require the server, while anonymous name/photo edits work offline.
Checklist