test(packages): remove stale Effect advisory gate remnants (#5890)

[proggeramlug]

Summary

Completes the cleanup left after #6572 closed #5890: the Effect fixture runs by default, so its CI invocation and package-test documentation should no longer describe or export the removed advisory gate.

Changes

• Stop exporting the unused PERRY_EFFECT_BASIC_ADVISORY variable in the named Effect smoke job.
• Document that Effect runs in both the default tier-3 sweep and its named advisory job.
• Clarify the fixture comment to identify test(packages): run effect-basic smoke by default (#5890) #6572 as the removal point for the historical gate.

Related issue

Refs #5890. Follow-up to #6572.

Test plan

• git diff --check
• .github/workflows/test.yml parses with PyYAML
• bash -n tests/release/packages/effect-basic/fixture.sh
• bash fixture.sh --__did-skip-marker exits 1 as expected
• cargo build --release (not run; no Rust changes)
• cargo test --workspace (not run; no Rust changes)

Checklist

• No workspace version, CLAUDE.md, or CHANGELOG.md changes
• Commit follows the repository prefix convention
• Read CONTRIBUTING.md and the Code of Conduct

Summary by CodeRabbit

• Tests

  • Updated the Effect fixture to run in its standard mode during CI validation.
  • Included the Effect fixture in both the default release sweep and its dedicated CI job.
  • Clarified fixture validation behavior and removed outdated advisory-mode references.

• Documentation

  • Updated release test documentation to reflect the current Effect and Ink validation workflows.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c456c187-d491-4d95-b64e-ca2675f8dfb7

📥 Commits

Reviewing files that changed from the base of the PR and between 06e1ab3 and 9aeafae.

📒 Files selected for processing (3)

• .github/workflows/test.yml
• tests/release/packages/README.md
• tests/release/packages/effect-basic/fixture.sh

Included review availability: Your plan provides up to 8 included reviews per hour; 2 remain after this review.

---

📝 Walkthrough

Walkthrough

The Effect fixture no longer receives PERRY_EFFECT_BASIC_ADVISORY=1. The fixture comment and package README now describe the updated runtime behavior.

Changes

Effect fixture execution

Layer / File(s)	Summary
Remove Effect advisory gate .github/workflows/test.yml, tests/release/packages/effect-basic/fixture.sh, tests/release/packages/README.md	The workflow runs the fixture with only PERRY_BIN. The fixture comment records removal of the historical gate. The README documents compilation and execution in tier-3 and the named CI job.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 9aeaf

This PR removes stale Effect advisory-gate references from CI documentation and fixture comments without changing test behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies removal of the stale Effect advisory gate, which is the primary change.
Description check	✅ Passed	The description includes the required summary, changes, issue reference, test plan, and checklist with relevant details.
Linked Issues check	✅ Passed	The changes implement the stated follow-up cleanup for #5890 by removing the obsolete gate and updating related documentation.
Out of Scope Changes check	✅ Passed	All changes are limited to CI configuration, package-test documentation, and a related fixture comment.
Docstring Coverage	✅ Passed	Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/5890-effect-smoke-cleanup

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[proggeramlug]

Landed on main in f5739b5 via #8677. Validation there: all nine ratchets, cargo check --workspace --all-targets clean, runtime 2648/0, codegen 1193/0.