Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3169,7 +3169,7 @@ jobs:
- name: Run Effect fixture
run: |
cd tests/release/packages/effect-basic
PERRY_EFFECT_BASIC_ADVISORY=1 PERRY_BIN="$GITHUB_WORKSPACE/target/release/perry" bash fixture.sh
PERRY_BIN="$GITHUB_WORKSPACE/target/release/perry" bash fixture.sh

- name: Upload Effect fixture logs
if: always()
Expand Down
10 changes: 5 additions & 5 deletions tests/release/packages/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ The harness defines its own pass/fail/skip totals; downstream consumers
The `effect-basic` and `ink-link-smoke` fixtures also have named CI jobs in
`.github/workflows/test.yml`. They run on release tags, on manual dispatch with
`run_extended_tests=true`, and on PRs with the `run-extended-tests` label. The
Effect job opts into a currently advisory compile/run signal with
`PERRY_EFFECT_BASIC_ADVISORY=1`; the default tier-3 sweep records it as SKIP so
known Effect end-to-end gaps do not block unrelated package releases. The Ink
job intentionally stops at compile/link plus symbol inspection; end-to-end Ink
rendering remains tracked separately from the release fixture contract.
Effect fixture compiles and runs in both the default tier-3 sweep and its named
job. The named job remains advisory, matching the tier-3 convention, so broader
Effect end-to-end gaps do not block unrelated changes. The Ink job intentionally
stops at compile/link plus symbol inspection; end-to-end Ink rendering remains
tracked separately from the release fixture contract.
2 changes: 1 addition & 1 deletion tests/release/packages/effect-basic/fixture.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ fi
# instead of skipping behind an opt-in flag. The CI job stays advisory
# (`continue-on-error: true`) per the tier-3 convention. The historical
# `PERRY_EFFECT_BASIC_ADVISORY=1` gate (added in #4391 when Effect reliably
# failed) is gone; the env var is now a harmless no-op.
# failed) was removed in #6572.

fixture_setup "$NAME" || exit 1
fixture_compile_run_diff "$NAME"
Loading