set language_level=3 for Cython#435
Merged
rgommers merged 2 commits intoPyWavelets:masterfrom Feb 4, 2019
Merged
Conversation
tacaswell
added a commit
to tacaswell/pywt
that referenced
this pull request
Feb 4, 2019
This is a simpler alternative to PyWavelets#435
as suggested by tacaswell in PyWaveletsgh-451
grlee77
force-pushed
the
cython_language_level
branch
from
a20d27e to
cf492ae
Compare
Contributor
Author
|
I rebased this on current master to get rid of all the already merged commits from #434. I then moved the language_level statement to |
Contributor
Author
|
The only change here to the Cython code aside from import syntax was the need to specify integer division at the following location: |
Member
|
LGTM, merged. Thanks @grlee77 |
Contributor
Author
|
I got a notification about failures on ReadtheDocs and will look into it. We probably just need to make sure the Cython version being used there is recent enough. |
Member
|
Ah yes, we're still pinning to Cython 0.20.2 in |
Contributor
Author
|
#452 should fix the documentation build |
grlee77
pushed a commit
to grlee77/pywt
that referenced
this pull request
Feb 10, 2019
This is a simpler alternative to PyWavelets#435
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not currently specify the Cython
language_level. This results in a warning from Cython 0.29 that the default is going to change fromlanguage_level=2tolanguage_level=3strin the future.As we are dropping Python 2 support in the next release, I thought we should just explicitly specify
language_level=3. This PR adds thelanguage_leveldirective at the top of each .pyx file.There was one place where
/needed to be//to maintain integer division. The rest of the changes are to the import statements and were necessary to get the files to compile under this language level.This is built on top of #434 so that the Python 2.7 test cases wouldn't be run. Only the c7c9c2f commit is new to this PR.