bump minimum supported Cython version#452
Merged
grlee77 merged 3 commits intoPyWavelets:masterfrom Feb 4, 2019
Merged
Conversation
Contributor
Author
|
I cancelled Appveyor as there were no changes to the scripts for windows here. Let's confirm whether the Travis case with 0.23.5 builds before merging this. |
Contributor
Author
|
It looks like 0.23.5 works. Should we just remove the pin altogether from the RTD I think it is good to leave at least one CI case with the minimum supported Cython as introduced here, but I'm not sure there is reason to not just use the most recent versions for building the docs? |
Member
|
makes sense to remove the pin completely |
grlee77
force-pushed
the
rtd_cython_fix
branch
from
3352808 to
b783fc4
Compare
grlee77
force-pushed
the
rtd_cython_fix
branch
from
b783fc4 to
288ccb3
Compare
Contributor
Author
|
done. let's merge and see if RTD is happy now |
Contributor
Author
|
I had to also log into readthedocs and wipe the build environment. Otherwise, it was still using the previously cached Cython 0.20. I manually triggered a rebuild over there and now it succeeded this time. |
grlee77
added a commit
that referenced
this pull request
Feb 26, 2019
MAINT 1.0.x backport #452 (bump minimum supported Cython version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readthedocs was pinned to Cython 0.20 which is too old to build the changes merged in #435. I am trying to bump to 0.23.5 here to see if that is new enough.
I added a test case on Travis with the minimum Cython version since it seems the CI test cases all just used the most recent release..