Skip to content

fix(ui): improve Russian translations - #118

Merged
Ray-lea merged 1 commit into
mainfrom
codex/consolidate-russian-translations
Nov 14, 2026
Merged

Ray-lea merged 1 commit into
mainfrom
codex/consolidate-russian-translations

Conversation

@Ray-lea

@Ray-lea Ray-lea commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Consolidates @Dimmitrius's Russian translation contributions into one reviewed commit: 117 wording improvements across 13 locale files.

Localizes CPU/GPU/I/O terminology and improves grammar, error messages and unit spacing. Preserves the meaning of accessible file-lock results, release builds, onboarding and the update sequence, along with percentage spacing and the latest tray description. Empty changes and purely stylistic rewrites are omitted.

Supersedes #92, #93, #94, #95, #96, #97, #98, #99, #100, #101, #102, #103, #104, #105, #106, #107, #108 and #109. Original authorship is credited in the commit.

Also restores the missing TrayIcon and TrayMenu imports in the command-adapter generator template. This fixes an existing CI mismatch while preserving the checked-in adapter exactly.

Validation: translation checks passed for all 8 locales (1,915 keys each), Biome checks, generator syntax and output checks, and git diff --check passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T15:00:15.856968Z 85b6de4 New commits
🔒 Security Review ✅ Completed 2026-11-14T15:01:58.547803Z 85b6de4 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

统一处理器、显卡与输入输出术语,改进错误提示、语法和单位排版。
从 #92–#109 的翻译提议中择优整合,保留技术含义、权限限定和更新操作顺序。
补齐命令适配器生成模板的托盘类型导入,使其与已提交的适配器保持一致。

Co-authored-by: Dmitry Yerokhin <erodim@mail.ru>
@Ray-lea
Ray-lea force-pushed the codex/consolidate-russian-translations branch from b55b5b8 to 85b6de4 Compare November 14, 2026 14:58

Ray-lea commented Nov 14, 2026

Copy link
Copy Markdown
Owner Author

Independent sub-agent review of 85b6de4 found no actionable issues in the 117 translation changes or the generator fix. Translation and generator checks passed; waiting for the remaining CI before merging.

@Ray-lea
Ray-lea merged commit b734e06 into main Nov 14, 2026
7 checks passed

Ray-lea commented Nov 14, 2026

Copy link
Copy Markdown
Owner Author

Independent review and all CI checks passed. Squash-merged as b734e06, preserving contributor credit. Thanks for the Russian translation improvements!

@hayxe1

hayxe1 commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

@Ray-lea Hey! I reviewed the Russian translation changes in #118. Russian is my native language, and I noticed that CPU, GPU, and I/O were changed to “ЦП”, “ГП”, and “В/В”.

Could we keep CPU, GPU, and I/O in their original form? I find these labels more recognizable in a hardware monitoring app. I wouldn’t call all the Russian equivalents incorrect, but I think the original abbreviations work better here, especially I/O instead of “В/В”.

I ran into the same issue while working on my earlier Russian translation PR (#62), where we specifically changed “В/В” back to I/O. Keeping that terminology consistent would be helpful. Thanks for continuing to improve the Russian translation!

@Dimmitrius

Copy link
Copy Markdown
Contributor

I can only agree with I/O. We need to focus on the accuracy of the translation, not on what we're used to. Otherwise, it's easy to slip into slang.

@Ray-lea
Ray-lea deleted the codex/consolidate-russian-translations branch November 14, 2026 22:15

Ray-lea commented Nov 14, 2026

Copy link
Copy Markdown
Owner Author

Thanks for the feedback, @hayxe1 and @Dimmitrius. I've pushed the follow-up to main.

Argus now uses CPU, GPU, and I/O as the standard UI abbreviations across all eight languages. The changes restore these abbreviations in Russian and resolve the mixed I/O terminology in Spanish, German, and French.

The follow-up also:

  • Standardizes capacity, transfer-rate, and hardware unit symbols, including GB, KiB, Hz, and V, while preserving regional number formatting and spacing.
  • Updates the corresponding website source text.
  • Expands the glossary to cover all eight languages and adds shared terminology checks to pnpm i18n for both the app and website. The rules also document the contexts where full explanatory phrases are translated.

This updates 68 app strings and 15 website strings. Validation passed: locale and formatting checks, 18 focused script tests, a development build, native-window checks in four languages, and website checks in five languages.

Commits: 0adc675, a30ba64, 2afc17c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants