Repository navigation
fix(ui): improve Russian translations - #118
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
b55b5b8 to
85b6de4
Compare
|
Independent sub-agent review of |
|
Independent review and all CI checks passed. Squash-merged as b734e06, preserving contributor credit. Thanks for the Russian translation improvements! |
|
@Ray-lea Hey! I reviewed the Russian translation changes in #118. Russian is my native language, and I noticed that CPU, GPU, and I/O were changed to “ЦП”, “ГП”, and “В/В”. Could we keep CPU, GPU, and I/O in their original form? I find these labels more recognizable in a hardware monitoring app. I wouldn’t call all the Russian equivalents incorrect, but I think the original abbreviations work better here, especially I/O instead of “В/В”. I ran into the same issue while working on my earlier Russian translation PR (#62), where we specifically changed “В/В” back to I/O. Keeping that terminology consistent would be helpful. Thanks for continuing to improve the Russian translation! |
|
I can only agree with I/O. We need to focus on the accuracy of the translation, not on what we're used to. Otherwise, it's easy to slip into slang. |
|
Thanks for the feedback, @hayxe1 and @Dimmitrius. I've pushed the follow-up to Argus now uses CPU, GPU, and I/O as the standard UI abbreviations across all eight languages. The changes restore these abbreviations in Russian and resolve the mixed I/O terminology in Spanish, German, and French. The follow-up also:
This updates 68 app strings and 15 website strings. Validation passed: locale and formatting checks, 18 focused script tests, a development build, native-window checks in four languages, and website checks in five languages. |
Consolidates @Dimmitrius's Russian translation contributions into one reviewed commit: 117 wording improvements across 13 locale files.
Localizes CPU/GPU/I/O terminology and improves grammar, error messages and unit spacing. Preserves the meaning of accessible file-lock results, release builds, onboarding and the update sequence, along with percentage spacing and the latest tray description. Empty changes and purely stylistic rewrites are omitted.
Supersedes #92, #93, #94, #95, #96, #97, #98, #99, #100, #101, #102, #103, #104, #105, #106, #107, #108 and #109. Original authorship is credited in the commit.
Also restores the missing
TrayIconandTrayMenuimports in the command-adapter generator template. This fixes an existing CI mismatch while preserving the checked-in adapter exactly.Validation: translation checks passed for all 8 locales (1,915 keys each), Biome checks, generator syntax and output checks, and
git diff --checkpassed.