fix: allow custom model names in Model Combo Box for static providers #10230
+60
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the generic Select component with ModelPicker for providers with static model lists (Anthropic, Mistral, Gemini, etc.). The ModelPicker component already supports entering custom model IDs that are not in the predefined list. This enables users to use newly released models from providers without waiting for Roo Code updates. Fixes #10229
Contributor
Author
Review complete. Found 1 issue to address.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Comment on lines
801
to
828
| <ModelPicker | ||
| apiConfiguration={apiConfiguration} | ||
| setApiConfigurationField={(field, value, isUserAction) => { | ||
| setApiConfigurationField(field, value, isUserAction) | ||
|
|
||
| // Handle special cases when model changes | ||
| if (field === "apiModelId") { | ||
| // Clear custom ARN if not using custom ARN option for Bedrock | ||
| if (value !== "custom-arn" && selectedProvider === "bedrock") { | ||
| setApiConfigurationField("awsCustomArn", "") | ||
| } | ||
|
|
||
| // Clear reasoning effort when switching models to allow the new model's default to take effect | ||
| // This is especially important for GPT-5 models which default to "medium" | ||
| if (selectedProvider === "openai-native") { | ||
| setApiConfigurationField("reasoningEffort", undefined) | ||
| } | ||
| }}> | ||
| <SelectTrigger className="w-full"> | ||
| <SelectValue placeholder={t("settings:common.select")} /> | ||
| </SelectTrigger> | ||
| <SelectContent> | ||
| {selectedProviderModels.map((option) => ( | ||
| <SelectItem key={option.value} value={option.value}> | ||
| {option.label} | ||
| </SelectItem> | ||
| ))} | ||
| {selectedProvider === "bedrock" && ( | ||
| <SelectItem value="custom-arn">{t("settings:labels.useCustomArn")}</SelectItem> | ||
| )} | ||
| </SelectContent> | ||
| </Select> | ||
| </div> | ||
|
|
||
| {/* Show error if a deprecated model is selected */} | ||
| {selectedModelInfo?.deprecated && ( | ||
| <ApiErrorMessage errorMessage={t("settings:validation.modelDeprecated")} /> | ||
| )} | ||
| } | ||
| }} | ||
| defaultModelId={staticProviderDefaultModelId} | ||
| models={staticProviderModels} | ||
| modelIdKey="apiModelId" | ||
| serviceName={staticProviderLabel} | ||
| serviceUrl={docs?.url || ""} | ||
| organizationAllowList={organizationAllowList} | ||
| simplifySettings={fromWelcomeView} | ||
| hidePricing | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
The Bedrock "Use Custom ARN" option is no longer discoverable after this change. Previously, Bedrock users saw an explicit SelectItem with the label t("settings:labels.useCustomArn") in the dropdown. Now they must know to type "custom-arn" manually in the search field. Consider adding "custom-arn" to the staticProviderModels for Bedrock (perhaps with a descriptive label) or extending the ModelPicker to support provider-specific extra options.
Fix it with Roo Code or mention @roomote and request a fix.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #10229
Description
This PR attempts to address Issue #10229 by replacing the generic
Selectcomponent with the existingModelPickercomponent for providers with static model lists (Anthropic, Mistral, Gemini, Bedrock, etc.).Key changes:
ModelPickercomponent already supports entering custom model IDs that are not in the predefined list (via the search field)Affected providers: Anthropic, Bedrock, Cerebras, DeepSeek, Doubao, Moonshot, Gemini, Mistral, OpenAI Native, Qwen Code, Vertex, xAI, Groq, SambaNova, Z.ai, Fireworks, Featherless, MiniMax, and Baseten.
Test Procedure
Pre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome!