Repository navigation
fix(feed): prevent group name subtitle leak into other fragments (#13366) - #13974
Conversation
TobiGr
left a comment
There was a problem hiding this comment.
Thank you. Please remove the equivalent part in onDestroy() as it is not needed anymore.
| /** | ||
| * Clears the action bar subtitle when leaving the fragment to prevent | ||
| * the feed group name from leaking into subsequent views (#13366). | ||
| */ | ||
| override fun onStop() { | ||
| super.onStop() | ||
| // Clear subtitle only if it currently matches group name. |
There was a problem hiding this comment.
A general note about your code: please remove the inline comment as it is just describing what the code does and replace it with the JDoc text. The JDoc is thought to be for the whole method. And the method's purpose is not to fix this bug.
So please replace the inline comment with the text from the moethod's JDoc.
There was a problem hiding this comment.
Thank you for the clear feedback.
I've removed the redundant code from onDestroy(), updated onStop(), and cleaned up the JDoc.
Ready for another look when you have a moment.
There was a problem hiding this comment.
thank you. I pushed a commit correcting the comment.
|



What is it?
Description of the changes in your PR
onResume()inFeedFragment.ktto restore/re-apply thegroupNamesubtitle when returning to the feed tab.onStop()to safely clear the action bar subtitle if it matchesgroupName, preventing it from leaking into subsequent views when navigating away.Before/After Screen Record
before.mp4
update.mp4
Fixes the following issue(s)
Testing/QA
Devices
Steps for testing
APK for testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence