Final checks / modifications before submitting to CRAN#74
Open
Final checks / modifications before submitting to CRAN#74
Conversation
…in comparing int with uword
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and cleanups to the build system, development environment, and documentation for the
netdiffuseRpackage. The most significant changes include the removal of the customconfigureframework in favor of standard R mechanisms for OpenMP, updates to GitHub Actions workflows and development container setup, and minor documentation and code maintenance.Build system and configuration cleanup:
configureframework and associated scripts, relying instead on R's built-in support for OpenMP and simplifying the build process. This includes deletingconfigure.ac,cleanup, and template Makevars files, and updatingsrc/Makevarsandsrc/Makevars.winto use standard R variables for OpenMP flags. [1] [2] [3] [4] [5].Rbuildignoreto stop ignoringsrc/Makevars, ensuring the correct file is included in the build.Continuous integration and development environment:
actions/checkout@v6,actions/upload-artifact@v7, andactions/deploy-pages@v5, improving CI reliability and security. [1] [2] [3] [4] [5]Documentation and versioning:
1.25.0), includingREADME.mdandNEWS.md, and listed new user-visible and internal changes. [1] [2] [3] [4] [5]--vanillaflag from Rscript calls for consistency. [1] [2] [3]Code maintenance:
src/plot.cppby adding explicit type casts in size checks.These changes collectively modernize the package infrastructure, improve maintainability, and ensure compatibility with current R and CI tooling.