Skip to content

Add Pool swap fee growth direction tests#1047

Open
TUPM96 wants to merge 1 commit into
Uniswap:mainfrom
TUPM96:codex/pool-fee-growth-direction-tests
Open

Add Pool swap fee growth direction tests#1047
TUPM96 wants to merge 1 commit into
Uniswap:mainfrom
TUPM96:codex/pool-fee-growth-direction-tests

Conversation

@TUPM96

@TUPM96 TUPM96 commented May 25, 2026

Copy link
Copy Markdown

Summary

  • add deterministic Pool.swap coverage for fee-growth direction in zeroForOne and oneForZero swaps
  • cover both exact-input and exact-output paths
  • assert that only the input-token feeGrowthGlobal accumulator changes

Closes #606.

Tests

  • forge test --match-contract PoolTest --summary -vv
  • forge build
  • git diff --check

Copilot AI review requested due to automatic review settings May 25, 2026 09:46
@TUPM96 TUPM96 requested a review from a team as a code owner May 25, 2026 09:46
@TUPM96 TUPM96 mentioned this pull request May 25, 2026
Open
Copilot AI reviewed May 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flipping zeroForOne before fee indices assignment in Pool.swap doesn't cause the tests to fail

2 participants

@TUPM96