Skip to content

Add Pool swap fee growth direction tests #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TUPM96 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Pool swap fee growth direction tests #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions test/libraries/Pool.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,22 @@ contract PoolTest is Test {
}
}

function test_swap_exactInputZeroForOneAccruesOnlyToken0Fees() public {
_assertSwapFeeGrowthDirection(true, -1 ether);
}

function test_swap_exactOutputZeroForOneAccruesOnlyToken0Fees() public {
_assertSwapFeeGrowthDirection(true, 1 ether);
}

function test_swap_exactInputOneForZeroAccruesOnlyToken1Fees() public {
_assertSwapFeeGrowthDirection(false, -1 ether);
}

function test_swap_exactOutputOneForZeroAccruesOnlyToken1Fees() public {
_assertSwapFeeGrowthDirection(false, 1 ether);
}

function test_fuzz_tickSpacingToMaxLiquidityPerTick(int24 tickSpacing) public pure {
tickSpacing = int24(bound(tickSpacing, TickMath.MIN_TICK_SPACING, TickMath.MAX_TICK_SPACING));
// v3 math
Expand All @@ -179,4 +195,40 @@ contract PoolTest is Test {
// assert that the result is the same as the v3 math or lower
assertGe(type(uint128).max / numTicks, Pool.tickSpacingToMaxLiquidityPerTick(tickSpacing));
}

function _assertSwapFeeGrowthDirection(bool zeroForOne, int256 amountSpecified) internal {
_initializeWithLiquidity();

state.swap(
Pool.SwapParams({
amountSpecified: amountSpecified,
tickSpacing: 60,
zeroForOne: zeroForOne,
sqrtPriceLimitX96: zeroForOne ? Constants.SQRT_PRICE_1_2 : Constants.SQRT_PRICE_2_1,
lpFeeOverride: 0
})
);

if (zeroForOne) {
assertGt(state.feeGrowthGlobal0X128, 0);
assertEq(state.feeGrowthGlobal1X128, 0);
} else {
assertEq(state.feeGrowthGlobal0X128, 0);
assertGt(state.feeGrowthGlobal1X128, 0);
}
}

function _initializeWithLiquidity() internal {
state.initialize(Constants.SQRT_PRICE_1_1, 3000);
state.modifyLiquidity(
Pool.ModifyLiquidityParams({
owner: address(this),
tickLower: -120,
tickUpper: 120,
liquidityDelta: 10_000 ether,
tickSpacing: 60,
salt: 0
})
);
}
}