Skip to content

Add ERC6909 swap settings coverage#1048

Open
TUPM96 wants to merge 1 commit into
Uniswap:mainfrom
TUPM96:codex/erc6909-swap-coverage-428
Open

Add ERC6909 swap settings coverage#1048
TUPM96 wants to merge 1 commit into
Uniswap:mainfrom
TUPM96:codex/erc6909-swap-coverage-428

Conversation

@TUPM96

@TUPM96 TUPM96 commented May 25, 2026

Copy link
Copy Markdown

Summary

  • Adds a fuzz test for the PoolSwapTest TestSettings matrix.
  • Seeds ERC6909 input claims when settleUsingBurn is enabled.
  • Asserts ERC20 balances and ERC6909 claim balances match the swap BalanceDelta for both take and burn paths.

Closes #428

Testing

  • forge fmt --check test/PoolManager.t.sol
  • forge test --isolate --match-contract PoolManagerTest --match-test test_swap_withERC6909Settings -vvv
  • forge test --isolate --match-contract PoolManagerTest -vv
  • git diff --check

Copilot AI review requested due to automatic review settings May 25, 2026 10:34
@TUPM96 TUPM96 requested a review from a team as a code owner May 25, 2026 10:34
@TUPM96 TUPM96 mentioned this pull request May 25, 2026
Open
Copilot AI reviewed May 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better test coverage for ERC6909 code path

2 participants

@TUPM96