[TF] Fix regressions caused by recent Caber explosion change (with improvements) #1702
+71
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an update to #1697, which I have closed because I felt like it would be good to completely redo the commit history and start from scratch. I also have decided to improve it with more features that would benefit modders, and bring in an important bug fix that bugged Caber users.
This PR fixes some minor regressions from the Caber explosion change introduced in #1456, which includes:
To fix these, the Caber no longer uses DMG_MELEE explicitly. The changes are now checked amongst its existing TF_DMG_CUSTOM_STICKBOMB_EXPLOSION damage type, which brings the following changes:
This extended version of the PR also introduces the following changes:
There are no plans to introduce any reversions to the caber explosion using attributes (as mentioned in ValveSoftware/Source-1-Games#7738) as there is no definite proof of there being a change to the Caber's explosive radius and damage.
Closes ValveSoftware/Source-1-Games#4428.